Serializer is always dependent on DATA_TYPE

Co-authored-by: Szymon Fiedler <[email protected]>
Co-authored-by: Mirosław Pragłowski <[email protected]>

Author: 3 people

ruby_event_store-active_record/spec/event_repository_spec.rb

@@ -8,17 +8,18 @@ module RubyEventStore
   module ActiveRecord
     ::RSpec.describe EventRepository do
       helper = SpecHelper.new
-      mk_repository = -> do
-        serializer =
-          case ENV["DATA_TYPE"]
-          when /json/
-            JSON
-          else
-            RubyEventStore::Serializers::YAML
-          end
-        EventRepository.new(serializer: serializer)
+
+      mk_serializer = -> do
+        case ENV["DATA_TYPE"]
+        when /json/
+          JSON
+        else
+          RubyEventStore::Serializers::YAML
+        end
       end
 
+      mk_repository = -> { EventRepository.new(serializer: mk_serializer.call) }
+
       it_behaves_like "event repository", mk_repository, helper
 
       let(:repository) { mk_repository.call }
@@ -74,7 +75,7 @@ module ActiveRecord
       end
 
       specify "use default models" do
-        repository = EventRepository.new(serializer: Serializers::YAML)
+        repository = EventRepository.new(serializer: mk_serializer.call)
         expect(repository.instance_variable_get(:@event_klass)).to be(Event)
         expect(repository.instance_variable_get(:@stream_klass)).to be(EventInStream)
       end
@@ -83,7 +84,7 @@ module ActiveRecord
         repository =
           EventRepository.new(
             model_factory: WithAbstractBaseClass.new(CustomApplicationRecord),
-            serializer: Serializers::YAML,
+            serializer: mk_serializer.call,
           )
         expect(repository.instance_variable_get(:@event_klass).ancestors).to include(CustomApplicationRecord)
         expect(repository.instance_variable_get(:@stream_klass).ancestors).to include(CustomApplicationRecord)
@@ -93,7 +94,7 @@ module ActiveRecord
         repository =
           EventRepository.new(
             model_factory: WithAbstractBaseClass.new(CustomApplicationRecord),
-            serializer: Serializers::YAML,
+            serializer: mk_serializer.call,
           )
         repository.append_to_stream([event = SRecord.new], Stream.new(GLOBAL_STREAM), ExpectedVersion.any)
         reader = SpecificationReader.new(repository, Mappers::Default.new)

ruby_event_store-active_record/spec/with_abstract_base_class_spec.rb

@@ -9,6 +9,15 @@ module ActiveRecord
     ::RSpec.describe WithAbstractBaseClass do
       include SchemaHelper
 
+      mk_serializer = -> do
+        case ENV["DATA_TYPE"]
+        when /json/
+          JSON
+        else
+          RubyEventStore::Serializers::YAML
+        end
+      end
+
       specify "Base for event factory models must be an abstract class" do
         NonAbstractClass = Class.new(::ActiveRecord::Base)
         expect { WithAbstractBaseClass.new(NonAbstractClass) }.to raise_error(ArgumentError).with_message(
@@ -53,7 +62,7 @@ module ActiveRecord
           repository =
             EventRepository.new(
               model_factory: WithAbstractBaseClass.new(CustomApplicationRecord),
-              serializer: Serializers::YAML,
+              serializer: mk_serializer.call,
             )
           repository.append_to_stream([event = SRecord.new], Stream.new(GLOBAL_STREAM), ExpectedVersion.any)
           reader = SpecificationReader.new(repository, Mappers::Default.new)
@@ -73,7 +82,7 @@ module ActiveRecord
           repository =
             EventRepository.new(
               model_factory: WithAbstractBaseClass.new(CustomApplicationRecord),
-              serializer: Serializers::YAML,
+              serializer: mk_serializer.call,
             )
           repository.append_to_stream(
             [event = SRecord.new(event_type: "Dummy")],