Skip to content

Commit 56cd783

Browse files
committed
fix: bench/stream-readable.mjs
1 parent 93aedcf commit 56cd783

File tree

1 file changed

+29
-40
lines changed

1 file changed

+29
-40
lines changed

bench/stream-readable.mjs

Lines changed: 29 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,45 @@
11
import { skipIfVersion } from '../utils.mjs'
22
import { Readable } from 'node:stream'
33
import { ReadableStream } from 'node:stream/web'
4+
import assert from 'node:assert'
45
import { createBenchmarkSuite } from '../common.mjs'
56

67
skipIfVersion('<= 16.5.0')
78

89
const suite = createBenchmarkSuite('Stream.Readable')
910

1011
suite
11-
.add('streams.Readable reading 1e3 * "some data"', {
12-
defer: true,
13-
fn: async function (deferred) {
14-
function* readImpl(_sizeT) {
15-
let i = 0
16-
while (i < 1e3) {
17-
yield 'some data'
18-
++i
19-
}
12+
.add('streams.Readable reading 1e3 * "some data"', async () => {
13+
function* readImpl(_sizeT) {
14+
let i = 0
15+
while (i < 1e3) {
16+
yield 'some data'
17+
++i
2018
}
21-
const readable = Readable.from(readImpl())
19+
}
20+
const readable = Readable.from(readImpl())
2221

23-
try {
24-
for await (const _ of readable) {
22+
for await (const _ of readable) {
23+
assert.ok(_)
24+
}
25+
},
26+
)
27+
.add('streams.web.Readable reading 1e3 * "some data"', async () => {
28+
let i = 0
29+
const readable = new ReadableStream({
30+
pull: function (controller) {
31+
controller.enqueue('some data')
32+
++i
33+
if (i >= 1e3) {
34+
controller.close()
2535
}
26-
deferred.resolve()
27-
} catch (e) {
28-
deferred.reject(e)
29-
}
30-
},
31-
})
32-
.add('streams.web.Readable reading 1e3 * "some data"', {
33-
defer: true,
34-
fn: async function (deferred) {
35-
let i = 0
36-
const readable = new ReadableStream({
37-
pull: function (controller) {
38-
controller.enqueue('some data')
39-
++i
40-
if (i >= 1e3) {
41-
controller.close()
42-
}
43-
},
44-
})
36+
},
37+
})
4538

46-
try {
47-
for await (const _ of readable) {
48-
}
49-
deferred.resolve()
50-
} catch (e) {
51-
deferred.reject(e)
52-
}
53-
},
54-
})
39+
for await (const _ of readable) {
40+
assert.ok(_)
41+
}
42+
},
43+
)
5544

5645
await suite.runAndPrintResults()

0 commit comments

Comments
 (0)