Skip to content

StandardButtons ignore selected language #2833

New issue
New issue
Closed
#2837
PrismLauncher/Translations
#19
Closed
StandardButtons ignore selected language#2833
#2837
PrismLauncher/Translations
#19
Labels
bugSomething isn't working
@Kationor

Description

@Kationor
Kationor
opened on Sep 17, 2024

Operating System

Windows

Version of Prism Launcher

Prism Launcher 8.4, develop at dc67807

Version of Qt

Qt 6.7.1 (stable), Qt 6.7.2 (develop)

Description of bug

When selecting a different language, the standard buttons provided by Qt should also be translated. This is not the case.

GPUyBxM4R7ZA7mTd

Steps to reproduce

  • Change Prism's language to something other than English
  • Observe that the StandardButtons do not get translated appropriately

Suspected cause

These translation files are not present.

PrismLauncher/launcher/translations/TranslationsModel.cpp

Lines 481 to 490 in dc67807

// FIXME: this is likely never present. FIX IT.
d->m_qt_translator.reset(new QTranslator());
if (d->m_qt_translator->load("qt_" + langCode, QLibraryInfo::location(QLibraryInfo::TranslationsPath))) {
qDebug() << "Loading Qt Language File for" << langCode.toLocal8Bit().constData() << "...";
if (!QCoreApplication::installTranslator(d->m_qt_translator.get())) {
qCritical() << "Loading Qt Language File failed.";
d->m_qt_translator.reset();
} else {
successful = true;
}

(Code itself works, tested by manually placing the appropriate files there.)

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions