From 668095c9d8b10f1c719ddada380285a8c5a62f80 Mon Sep 17 00:00:00 2001 From: Rob Holt Date: Thu, 2 Jan 2020 14:13:49 -0800 Subject: [PATCH 1/2] Make PowerShell names case insensitive --- src/session.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/session.ts b/src/session.ts index 5a2cd3a6ac..cdd3c1b610 100644 --- a/src/session.ts +++ b/src/session.ts @@ -127,7 +127,8 @@ export class SessionManager implements Middleware { let powerShellExeDetails; if (this.sessionSettings.powerShellDefaultVersion) { for (const details of this.powershellExeFinder.enumeratePowerShellInstallations()) { - if (details.displayName === this.sessionSettings.powerShellDefaultVersion) { + const wantedName = this.sessionSettings.powerShellDefaultVersion; + if (wantedName.localeCompare(details.displayName, undefined, { sensitivity: "accent" }) === 0) { powerShellExeDetails = details; break; } From 20a96f80d932a8fe82edebd0d205c2e4efe6c201 Mon Sep 17 00:00:00 2001 From: Rob Holt Date: Mon, 6 Jan 2020 15:47:00 -0800 Subject: [PATCH 2/2] Add SO link --- src/session.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/session.ts b/src/session.ts index cdd3c1b610..e934994312 100644 --- a/src/session.ts +++ b/src/session.ts @@ -127,6 +127,7 @@ export class SessionManager implements Middleware { let powerShellExeDetails; if (this.sessionSettings.powerShellDefaultVersion) { for (const details of this.powershellExeFinder.enumeratePowerShellInstallations()) { + // Need to compare names case-insensitively, from https://stackoverflow.com/a/2140723 const wantedName = this.sessionSettings.powerShellDefaultVersion; if (wantedName.localeCompare(details.displayName, undefined, { sensitivity: "accent" }) === 0) { powerShellExeDetails = details;