LinuxFile reused scratch buffers ensuring size was suaable. But the limit value cannot be modified so later usage failed as an intended overwrite

Author: taartspi

libraries/pi4j-library-linuxfs/src/main/java/com/pi4j/library/linuxfs/LinuxFile.java

@@ -211,34 +211,38 @@ protected static int getWordSize() {
     protected synchronized IntBuffer getOffsetsBuffer(int size) {
         final int byteSize = size * 4;
         IntBuffer buf = localOffsetsBuffer.get();
-
+        if (buf != null) {
+            // always reallocate buffer to ensure correct limits
+            localOffsetsBuffer.remove();
+            buf = localOffsetsBuffer.get();
+        }
         if (byteSize > localBufferSize)
             throw new ScratchBufferOverrun();
 
-        if (buf == null) {
-            ByteBuffer bb = ByteBuffer.allocateDirect(localBufferSize);
+        ByteBuffer bb = ByteBuffer.allocateDirect(localBufferSize);
 
-            //keep native order, set before cast to IntBuffer
-            bb.order(ByteOrder.nativeOrder());
+        //keep native order, set before cast to IntBuffer
+        bb.order(ByteOrder.nativeOrder());
 
-            buf = bb.asIntBuffer();
-            localOffsetsBuffer.set(buf);
-        }
+        buf = bb.asIntBuffer();
+        localOffsetsBuffer.set(buf);
 
         return buf;
     }
 
 
     protected  synchronized ByteBuffer getDataBuffer(int size) {
         ByteBuffer buf = localDataBuffer.get();
-
+        if (buf != null) {
+            // always reallocate buffer to ensure correct limits
+            localDataBuffer.remove();
+            buf = localDataBuffer.get();
+        }
         if (size > localBufferSize)
             throw new ScratchBufferOverrun();
 
-        if (buf == null) {
-            buf = ByteBuffer.allocateDirect(size);
-            localDataBuffer.set(buf);
-        }
+        buf = ByteBuffer.allocateDirect(size);
+        localDataBuffer.set(buf);
 
         return buf;
     }