Fixed potential issue with wrong result type set on pin/unpin methods of PFObject. #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.unpin.fix
branch
from
1fa1530 to
b7a818e
Compare
Contributor
|
I can't wait till we can have a compiler warning for a lack of generic type, personally. |
Contributor
Author
|
Yeah, that would be extremely helpful. |
nlutsenko
added a commit
that referenced
this pull request
Dec 29, 2015
Fixed potential issue with wrong result type set on pin/unpin methods of PFObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that some of these methods might return earlier - there could be
nilresult set onpin/unpinresult tasks. This fixes the issue by enforcing generic types across bothPFPinningObjectStoreandPFObjectimplementation.Contributes to #604, #563