fix: Addresses #341 (gracefully ignore bad rate limit data in paginators)

Louis Béranger · Louis Béranger · commit 3b764af56a0b · 2022-08-15T20:47:17.000+02:00
diff --git a/src/paginators/TwitterPaginator.ts b/src/paginators/TwitterPaginator.ts
@@ -32,6 +32,10 @@ export abstract class TwitterPaginator<TApiResult, TApiParams extends object, TI
   }
 
   protected get _isRateLimitOk() {
+    if (!this._rateLimit) {
+      return true;
+    }
+
     const resetDate = this._rateLimit.reset * 1000;
 
     if (resetDate < Date.now()) {
@@ -137,7 +141,7 @@ export abstract class TwitterPaginator<TApiResult, TApiParams extends object, TI
   }
 
   get rateLimit() {
-    return { ...this._rateLimit };
+    return { ...this._rateLimit ?? {} };
   }
 
   /** Get raw data returned by Twitter API. */

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ export abstract class TwitterPaginator<TApiResult, TApiParams extends object, TI`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`protected get _isRateLimitOk() {`
	`35`	`+ if (!this._rateLimit) {`
	`36`	`+ return true;`
	`37`	`+ }`
	`38`	`+`
`35`	`39`	`const resetDate = this._rateLimit.reset * 1000;`
`36`	`40`
`37`	`41`	`if (resetDate < Date.now()) {`
`@@ -137,7 +141,7 @@ export abstract class TwitterPaginator<TApiResult, TApiParams extends object, TI`
`137`	`141`	`}`
`138`	`142`
`139`	`143`	`get rateLimit() {`
`140`		`- return { ...this._rateLimit };`
	`144`	`+ return { ...this._rateLimit ?? {} };`
`141`	`145`	`}`
`142`	`146`
`143`	`147`	`/** Get raw data returned by Twitter API. */`