Fixed an XML bug leading to an infinite loop + Added xmlns attribute for 'DAV:' presence in a tag name

Author: AdrienCastex

lib/helper/XML.js

@@ -21,6 +21,8 @@ function seekForNS(node, parentNS) {
 }
 function mutateNodeNS(node, parentNS) {
     if (parentNS === void 0) { parentNS = { _default: 'DAV:' }; }
+    if (!node)
+        return;
     var nss = seekForNS(node, parentNS);
     if (node.name) {
         for (var ns in nss) {
@@ -36,14 +38,14 @@ function mutateNodeNS(node, parentNS) {
     }
     node.findIndex = function (name) {
         for (var index = 0; index < node.elements.length; ++index)
-            if (node.elements[index].name && node.elements[index].name === name)
+            if (node.elements[index] && node.elements[index].name && node.elements[index].name === name)
                 return index;
         return -1;
     };
     node.find = function (name) {
         for (var _i = 0, _a = node.elements; _i < _a.length; _i++) {
             var element = _a[_i];
-            if (element.name && element.name === name)
+            if (element && element.name && element.name === name)
                 return element;
         }
         throw Errors_1.Errors.XMLNotFound;
@@ -52,7 +54,7 @@ function mutateNodeNS(node, parentNS) {
         var elements = [];
         for (var _i = 0, _a = node.elements; _i < _a.length; _i++) {
             var element = _a[_i];
-            if (element.name && element.name === name)
+            if (element && element.name && element.name === name)
                 elements.push(element);
         }
         return elements;
@@ -103,11 +105,11 @@ var XML = (function () {
             attributes = {};
         var li1 = name.lastIndexOf(':');
         var li2 = name.indexOf(':');
-        var lindex = Math.max(li1 === li2 ? -1 : li1, name.lastIndexOf('/')) + 1;
+        var lindex = Math.max(li1 === li2 && name.indexOf('DAV:') !== 0 ? -1 : li1, name.lastIndexOf('/')) + 1;
         if (lindex !== 0) {
             var kname = 'a';
             var value = name.substring(0, lindex);
-            while (attributes['xmlns:' + kname] !== undefined || value.indexOf(kname + ':') === -1) {
+            while (attributes['xmlns:' + kname] !== undefined || value.indexOf(kname + ':') === 0) {
                 var newChar = kname.charCodeAt(0) + 1;
                 if (newChar > 'z'.charCodeAt(0))
                     kname = 'x' + String.fromCharCode(newChar);

src/helper/XML.ts

@@ -26,6 +26,9 @@ function seekForNS(node : any, parentNS : any) : any
 
 function mutateNodeNS(node : any, parentNS = { _default: 'DAV:' })
 {
+    if(!node)
+        return;
+    
     const nss = seekForNS(node, parentNS);
 
     if(node.name)
@@ -48,14 +51,14 @@ function mutateNodeNS(node : any, parentNS = { _default: 'DAV:' })
     node.findIndex = function(name : string) : number
     {
         for(let index = 0; index < node.elements.length; ++index)
-            if(node.elements[index].name && node.elements[index].name === name)
+            if(node.elements[index] && node.elements[index].name && node.elements[index].name === name)
                 return index;
         return -1;
     }
     node.find = function(name : string) : XMLElement
     {
         for(const element of node.elements)
-            if(element.name && element.name === name)
+            if(element && element.name && element.name === name)
                 return element;
         throw Errors.XMLNotFound;
     }
@@ -64,7 +67,7 @@ function mutateNodeNS(node : any, parentNS = { _default: 'DAV:' })
         const elements : XMLElement[] = [];
 
         for(const element of node.elements)
-            if(element.name && element.name === name)
+            if(element && element.name && element.name === name)
                 elements.push(element);
 
         return elements;
@@ -139,12 +142,12 @@ export abstract class XML
 
         const li1 = name.lastIndexOf(':');
         const li2 = name.indexOf(':');
-        const lindex = Math.max(li1 === li2 ? -1 : li1, name.lastIndexOf('/')) + 1;
+        const lindex = Math.max(li1 === li2 && name.indexOf('DAV:') !== 0 ? -1 : li1, name.lastIndexOf('/')) + 1;
         if(lindex !== 0)
         {
             let kname = 'a';
             const value = name.substring(0, lindex);
-            while(attributes['xmlns:' + kname] !== undefined || value.indexOf(kname + ':') === -1)
+            while(attributes['xmlns:' + kname] !== undefined || value.indexOf(kname + ':') === 0)
             {
                 const newChar = kname.charCodeAt(0) + 1;
                 if(newChar > 'z'.charCodeAt(0))