Skip to content

Commit 155035c

Browse files
committed
Used more standard errors
1 parent ec514e0 commit 155035c

File tree

11 files changed

+25
-16
lines changed

11 files changed

+25
-16
lines changed

lib/Errors.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ export declare const Errors: {
2222
UserNotFound: Error;
2323
XMLNotFound: Error;
2424
ExpectedAFileResourceType: Error;
25+
NoMimeTypeForAFolder: Error;
26+
NoSizeForAFolder: Error;
27+
IllegalArguments: Error;
2528
None: any;
2629
};
2730
export default Errors;

lib/Errors.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ exports.Errors = {
4545
UserNotFound: new Error('User not found'),
4646
XMLNotFound: new Error('Can\'t find the XML element.'),
4747
ExpectedAFileResourceType: new Error('Expected a file resource type.'),
48+
NoMimeTypeForAFolder: new Error('Cannot get the mime type of a folder type resource'),
49+
NoSizeForAFolder: new Error('Cannot get the size of a folder type resource'),
50+
IllegalArguments: new Error('Illegal arguments'),
4851
None: null
4952
};
5053
exports.default = exports.Errors;

lib/resource/physical/PhysicalFolder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ var PhysicalFolder = (function (_super) {
7575
callback(Errors_1.Errors.InvalidOperation, null);
7676
};
7777
PhysicalFolder.prototype.mimeType = function (targetSource, callback) {
78-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
78+
callback(Errors_1.Errors.NoMimeTypeForAFolder, null);
7979
};
8080
PhysicalFolder.prototype.size = function (targetSource, callback) {
81-
callback(new Error('Cannot get the size of a folder type resource'), null);
81+
callback(Errors_1.Errors.NoSizeForAFolder, null);
8282
};
8383
PhysicalFolder.prototype.addChild = function (resource, callback) {
8484
var _this = this;

lib/resource/virtual/VirtualFolder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ var VirtualFolder = (function (_super) {
3131
callback(Errors_1.Errors.InvalidOperation, null);
3232
};
3333
VirtualFolder.prototype.mimeType = function (targetSource, callback) {
34-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
34+
callback(Errors_1.Errors.NoMimeTypeForAFolder, null);
3535
};
3636
VirtualFolder.prototype.size = function (targetSource, callback) {
37-
callback(new Error('Cannot get the size of a folder type resource'), null);
37+
callback(Errors_1.Errors.NoSizeForAFolder, null);
3838
};
3939
VirtualFolder.prototype.addChild = function (resource, callback) {
4040
var _this = this;

lib/resource/virtualStored/VirtualStoredFolder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ var VirtualStoredFolder = (function (_super) {
3131
callback(Errors_1.Errors.InvalidOperation, null);
3232
};
3333
VirtualStoredFolder.prototype.mimeType = function (targetSource, callback) {
34-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
34+
callback(Errors_1.Errors.NoMimeTypeForAFolder, null);
3535
};
3636
VirtualStoredFolder.prototype.size = function (targetSource, callback) {
37-
callback(new Error('Cannot get the size of a folder type resource'), null);
37+
callback(Errors_1.Errors.NoSizeForAFolder, null);
3838
};
3939
VirtualStoredFolder.prototype.addChild = function (resource, callback) {
4040
var _this = this;

lib/server/WebDAVServer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,14 @@ var WebDAVServer = (function () {
159159
if (callback instanceof Function)
160160
_callback = callback;
161161
else
162-
throw new Error('Illegal arguments');
162+
throw Errors_1.Errors.IllegalArguments;
163163
}
164164
}
165165
else if (port && port.constructor === Function) {
166166
_port = this.options.port;
167167
_callback = port;
168168
if (callback)
169-
throw new Error('Illegal arguments');
169+
throw Errors_1.Errors.IllegalArguments;
170170
}
171171
if (!this.server) {
172172
this.server = http.createServer(function (req, res) {

src/Errors.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ export const Errors = {
3131
UserNotFound: new Error('User not found'),
3232
XMLNotFound: new Error('Can\'t find the XML element.'),
3333
ExpectedAFileResourceType: new Error('Expected a file resource type.'),
34+
NoMimeTypeForAFolder: new Error('Cannot get the mime type of a folder type resource'),
35+
NoSizeForAFolder: new Error('Cannot get the size of a folder type resource'),
36+
IllegalArguments: new Error('Illegal arguments'),
3437

3538
None: null
3639
};

src/resource/physical/PhysicalFolder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,11 @@ export class PhysicalFolder extends PhysicalResource
9292
}
9393
mimeType(targetSource : boolean, callback : ReturnCallback<string>)
9494
{
95-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
95+
callback(Errors.NoMimeTypeForAFolder, null);
9696
}
9797
size(targetSource : boolean, callback : ReturnCallback<number>)
9898
{
99-
callback(new Error('Cannot get the size of a folder type resource'), null);
99+
callback(Errors.NoSizeForAFolder, null);
100100
}
101101

102102
// ****************************** Children ****************************** //

src/resource/virtual/VirtualFolder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ export class VirtualFolder extends VirtualResource
3434
}
3535
mimeType(targetSource : boolean, callback : ReturnCallback<string>)
3636
{
37-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
37+
callback(Errors.NoMimeTypeForAFolder, null);
3838
}
3939
size(targetSource : boolean, callback : ReturnCallback<number>)
4040
{
41-
callback(new Error('Cannot get the size of a folder type resource'), null);
41+
callback(Errors.NoSizeForAFolder, null);
4242
}
4343

4444
// ****************************** Children ****************************** //

src/resource/virtualStored/VirtualStoredFolder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ export class VirtualStoredFolder extends VirtualStoredResource
3434
}
3535
mimeType(targetSource : boolean, callback : ReturnCallback<string>)
3636
{
37-
callback(new Error('Cannot get the mime type of a folder type resource'), null);
37+
callback(Errors.NoMimeTypeForAFolder, null);
3838
}
3939
size(targetSource : boolean, callback : ReturnCallback<number>)
4040
{
41-
callback(new Error('Cannot get the size of a folder type resource'), null);
41+
callback(Errors.NoSizeForAFolder, null);
4242
}
4343

4444
// ****************************** Children ****************************** //

0 commit comments

Comments
 (0)