Renamed to SharedCacheKeyGenerator

Nyholm · Nyholm · commit c340f6ba04e2 · 2017-04-05T08:49:57.000+02:00
diff --git a/spec/Cache/Generator/SharedCacheKeyGeneratorSpec.php b/spec/Cache/Generator/SharedCacheKeyGeneratorSpec.php
@@ -5,7 +5,7 @@
 use PhpSpec\ObjectBehavior;
 use Psr\Http\Message\RequestInterface;
 
-class HeaderHashGeneratorSpec extends ObjectBehavior
+class SharedCacheKeyGeneratorSpec extends ObjectBehavior
 {
     public function let()
     {
@@ -14,7 +14,7 @@ public function let()
 
     public function it_is_initializable()
     {
-        $this->shouldHaveType('Http\Client\Common\Plugin\Cache\Generator\HeaderHashGenerator');
+        $this->shouldHaveType('Http\Client\Common\Plugin\Cache\Generator\SharedCacheKeyGenerator');
     }
 
     public function it_is_a_key_generator()
diff --git a/src/Cache/Generator/SharedCacheKeyGenerator.php b/src/Cache/Generator/SharedCacheKeyGenerator.php
@@ -5,11 +5,11 @@
 use Psr\Http\Message\RequestInterface;
 
 /**
- * Generate a cache key by specify what headers you want to vary on.
+ * Generate a cache key by vary on Cookie and Authorization header.
  *
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
  */
-class HeaderHashGenerator implements CacheKeyGenerator
+class SharedCacheKeyGenerator implements CacheKeyGenerator
 {
     /**
      * The header names we should take into account when creating the cache key.
@@ -19,9 +19,9 @@ class HeaderHashGenerator implements CacheKeyGenerator
     private $headerNames;
 
     /**
-     * @param $headerNames
+     * @param array $headerNames defaults to Authorization and Cookie
      */
-    public function __construct(array $headerNames)
+    public function __construct(array $headerNames = ['Authorization', 'Cookie'])
     {
         $this->headerNames = $headerNames;
     }

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`use PhpSpec\ObjectBehavior;`
`6`	`6`	`use Psr\Http\Message\RequestInterface;`
`7`	`7`
`8`		`-class HeaderHashGeneratorSpec extends ObjectBehavior`
	`8`	`+class SharedCacheKeyGeneratorSpec extends ObjectBehavior`
`9`	`9`	`{`
`10`	`10`	`public function let()`
`11`	`11`	`{`
`@@ -14,7 +14,7 @@ public function let()`
`14`	`14`
`15`	`15`	`public function it_is_initializable()`
`16`	`16`	`{`
`17`		`- $this->shouldHaveType('Http\Client\Common\Plugin\Cache\Generator\HeaderHashGenerator');`
	`17`	`+ $this->shouldHaveType('Http\Client\Common\Plugin\Cache\Generator\SharedCacheKeyGenerator');`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public function it_is_a_key_generator()`
Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,11 @@`
`5`	`5`	`use Psr\Http\Message\RequestInterface;`
`6`	`6`
`7`	`7`	`/**`
`8`		`- * Generate a cache key by specify what headers you want to vary on.`
	`8`	`+ * Generate a cache key by vary on Cookie and Authorization header.`
`9`	`9`	`*`
`10`	`10`	`* @author Tobias Nyholm <[email protected]>`
`11`	`11`	`*/`
`12`		`-class HeaderHashGenerator implements CacheKeyGenerator`
	`12`	`+class SharedCacheKeyGenerator implements CacheKeyGenerator`
`13`	`13`	`{`
`14`	`14`	`/**`
`15`	`15`	`* The header names we should take into account when creating the cache key.`
`@@ -19,9 +19,9 @@ class HeaderHashGenerator implements CacheKeyGenerator`
`19`	`19`	`private $headerNames;`
`20`	`20`
`21`	`21`	`/**`
`22`		`- * @param $headerNames`
	`22`	`+ * @param array $headerNames defaults to Authorization and Cookie`
`23`	`23`	`*/`
`24`		`- public function __construct(array $headerNames)`
	`24`	`+ public function __construct(array $headerNames = ['Authorization', 'Cookie'])`
`25`	`25`	`{`
`26`	`26`	`$this->headerNames = $headerNames;`
`27`	`27`	`}`