-
-
Notifications
You must be signed in to change notification settings - Fork 622
Support for hyperlinks attached to images #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think your suggestion is excellent! I've reviewed the code you shared and fully understand its purpose. I believe there are a couple of areas that could be improved:
If you're open to it, I'd be happy to submit a PR with these improvements and include you as a co-author! |
Thank you for your response! I'll go ahead and submit a PR that includes the improvements you mentioned. |
Uh oh!
There was an error while loading. Please reload this page.
While using the library, I thought it would be great to have native support for hyperlinks applied directly to images.
After reviewing this issue, it seems that links can be supported via image captions.
However, using captions to display hyperlinks feels a bit awkward, as it exposes the link directly within the Notion page.
I believe we could add support for actual image hyperlinks by modifying the asset-wrapper file directly. Here’s a snippet showing how this might be implemented:
This is my first time submitting an issue, so please let me know if there's anything I should improve.
Thank you!
The text was updated successfully, but these errors were encountered: