read default k8s namespace from config (#823)

Author: oavdeev

metaflow/metaflow_config.py

@@ -173,7 +173,7 @@ def from_conf(name, default=None):
 # Kubernetes configuration
 ###
 # Kubernetes namespace to use for all objects created by Metaflow
-KUBERNETES_NAMESPACE = from_conf("METAFLOW_KUBERNETES_NAMESPACE")
+KUBERNETES_NAMESPACE = from_conf("METAFLOW_KUBERNETES_NAMESPACE", "default")
 # Service account to use by K8S jobs created by Metaflow
 KUBERNETES_SERVICE_ACCOUNT = from_conf("METAFLOW_KUBERNETES_SERVICE_ACCOUNT")
 # Default container image for K8S

metaflow/plugins/aws/eks/kubernetes_client.py

@@ -107,9 +107,6 @@ def __init__(self, client_wrapper, **kwargs):
         self._client_wrapper = client_wrapper
         self._kwargs = kwargs
 
-        # Kubernetes namespace defaults to `default`
-        self._kwargs["namespace"] = self._kwargs["namespace"] or "default"
-
     def create(self):
         # Check that job attributes are sensible.
 

metaflow/plugins/aws/eks/kubernetes_decorator.py

@@ -11,6 +11,7 @@
     KUBERNETES_CONTAINER_IMAGE,
     KUBERNETES_CONTAINER_REGISTRY,
     DATASTORE_LOCAL_DIR,
+    KUBERNETES_NAMESPACE,
 )
 from metaflow.plugins import ResourcesDecorator
 from metaflow.plugins.timeout_decorator import get_run_time_limit_for_task
@@ -78,6 +79,8 @@ def my_step(self):
     def __init__(self, attributes=None, statically_defined=False):
         super(KubernetesDecorator, self).__init__(attributes, statically_defined)
 
+        if not self.attributes["namespace"]:
+            self.attributes["namespace"] = KUBERNETES_NAMESPACE
         # TODO: Unify the logic with AWS Batch
         # If no docker image is explicitly specified, impute a default image.
         if not self.attributes["image"]: