Fix PV sizing macro hanging issue

cpaulgilman · cpaulgilman · commit 21dfe96e837a · 2020-05-05T15:53:38.000-07:00
System Sizing.lk:

* Fix table color highlighting: loop to clear color for next iteration after setting color.

* List of suggested modules includes modules that result in String Voc &gt; Vmppt_max:  Limit list to modules that result in Vmppt_min &lt; String Voc &lt; Vmppt_max

* Macro takes too long to run for large arrays because many modules in library qualify for suggested modules tables: Limit list to show only modules that result in highest 50 String Voc values less than Vmppt_max.

* Using `left(module.name,4) == left(module{'lib'}{name}[i],4)` to identify manufacturer is insufficient

    * Add manufacturer name to module library and modify modules UI form to show manufacturer in library widget. CEC library script currently creates name by adding manufacturer and module name so that modules are sorted by manufacturer. Library widget does not have a filter feature, so this method makes it easier to find modules.

    * Use new manufacturer name field instead of reading first 4 characters of module name.

Flat Plate PV and PV Battery defaults

* Add new default variable for lib_manufacturer.

Module and Inverter libraries, clean up zeros after decimals.
diff --git a/deploy/libraries/CEC Inverters.csv b/deploy/libraries/CEC Inverters.csv
diff --git a/deploy/libraries/CEC Modules.csv b/deploy/libraries/CEC Modules.csv
diff --git a/deploy/runtime/defaults/Flat Plate PV_All Equity Partnership Flip.txt b/deploy/runtime/defaults/Flat Plate PV_All Equity Partnership Flip.txt
@@ -1,5 +1,5 @@
 1
-856
+857
 6par_aisc
 1
 1
@@ -3123,6 +3123,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Commercial.txt b/deploy/runtime/defaults/Flat Plate PV_Commercial.txt
@@ -1,5 +1,5 @@
 1
-790
+791
 6par_aisc
 1
 1
@@ -2436,6 +2436,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Host Developer.txt b/deploy/runtime/defaults/Flat Plate PV_Host Developer.txt
@@ -1,5 +1,5 @@
 1
-931
+932
 6par_aisc
 1
 1
@@ -3211,6 +3211,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_LCOE Calculator.txt b/deploy/runtime/defaults/Flat Plate PV_LCOE Calculator.txt
@@ -1,5 +1,5 @@
 1
-525
+526
 6par_aisc
 1
 1
@@ -1583,6 +1583,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Leveraged Partnership Flip.txt b/deploy/runtime/defaults/Flat Plate PV_Leveraged Partnership Flip.txt
@@ -1,5 +1,5 @@
 1
-866
+867
 6par_aisc
 1
 1
@@ -3157,6 +3157,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Merchant Plant.txt b/deploy/runtime/defaults/Flat Plate PV_Merchant Plant.txt
@@ -1,5 +1,5 @@
 1
-839
+840
 6par_aisc
 1
 1
@@ -2937,6 +2937,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_None.txt b/deploy/runtime/defaults/Flat Plate PV_None.txt
@@ -1,5 +1,5 @@
 1
-496
+497
 6par_aisc
 1
 1
@@ -1503,6 +1503,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Residential.txt b/deploy/runtime/defaults/Flat Plate PV_Residential.txt
@@ -1,5 +1,5 @@
 1
-820
+821
 6par_aisc
 1
 1
@@ -2535,6 +2535,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Sale Leaseback.txt b/deploy/runtime/defaults/Flat Plate PV_Sale Leaseback.txt
@@ -1,5 +1,5 @@
 1
-849
+850
 6par_aisc
 1
 1
@@ -3093,6 +3093,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Single Owner.txt b/deploy/runtime/defaults/Flat Plate PV_Single Owner.txt
@@ -1,5 +1,5 @@
 1
-865
+866
 6par_aisc
 1
 1
@@ -3151,6 +3151,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/Flat Plate PV_Third Party.txt b/deploy/runtime/defaults/Flat Plate PV_Third Party.txt
@@ -1,5 +1,5 @@
 1
-622
+623
 6par_aisc
 1
 1
@@ -1800,6 +1800,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_All Equity Partnership Flip.txt b/deploy/runtime/defaults/PV Battery_All Equity Partnership Flip.txt
@@ -1,5 +1,5 @@
 1
-1013
+1014
 6par_aisc
 1
 1
@@ -3997,6 +3997,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Commercial.txt b/deploy/runtime/defaults/PV Battery_Commercial.txt
@@ -1,5 +1,5 @@
 1
-959
+960
 6par_aisc
 1
 1
@@ -3389,6 +3389,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Host Developer.txt b/deploy/runtime/defaults/PV Battery_Host Developer.txt
@@ -1,5 +1,5 @@
 1
-1100
+1101
 6par_aisc
 1
 1
@@ -4164,6 +4164,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Leveraged Partnership Flip.txt b/deploy/runtime/defaults/PV Battery_Leveraged Partnership Flip.txt
@@ -1,5 +1,5 @@
 1
-1023
+1024
 6par_aisc
 1
 1
@@ -4031,6 +4031,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Merchant Plant.txt b/deploy/runtime/defaults/PV Battery_Merchant Plant.txt
@@ -1,5 +1,5 @@
 1
-996
+997
 6par_aisc
 1
 1
@@ -3809,6 +3809,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Residential.txt b/deploy/runtime/defaults/PV Battery_Residential.txt
@@ -1,5 +1,5 @@
 1
-989
+990
 6par_aisc
 1
 1
@@ -3488,6 +3488,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Sale Leaseback.txt b/deploy/runtime/defaults/PV Battery_Sale Leaseback.txt
@@ -1,5 +1,5 @@
 1
-1006
+1007
 6par_aisc
 1
 1
@@ -3967,6 +3967,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Single Owner.txt b/deploy/runtime/defaults/PV Battery_Single Owner.txt
@@ -1,5 +1,5 @@
 1
-1061
+1062
 6par_aisc
 1
 1
@@ -4031,6 +4031,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/defaults/PV Battery_Third Party.txt b/deploy/runtime/defaults/PV Battery_Third Party.txt
@@ -1,5 +1,5 @@
 1
-786
+787
 6par_aisc
 1
 1
@@ -2724,6 +2724,10 @@ lib_is_bifacial
 1
 1
 0
+lib_manufacturer
+1
+4
+0
 library_folder_list
 1
 4
diff --git a/deploy/runtime/macros/Flat Plate PV/System Sizing.lk b/deploy/runtime/macros/Flat Plate PV/System Sizing.lk
diff --git a/deploy/runtime/ui/CEC Performance Model with Module Database.txt b/deploy/runtime/ui/CEC Performance Model with Module Database.txt

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-856`
	`2`	`+857`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -3123,6 +3123,10 @@ lib_is_bifacial`
`3123`	`3123`	`1`
`3124`	`3124`	`1`
`3125`	`3125`	`0`
	`3126`	`+lib_manufacturer`
	`3127`	`+1`
	`3128`	`+4`
	`3129`	`+0`
`3126`	`3130`	`library_folder_list`
`3127`	`3131`	`1`
`3128`	`3132`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-790`
	`2`	`+791`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -2436,6 +2436,10 @@ lib_is_bifacial`
`2436`	`2436`	`1`
`2437`	`2437`	`1`
`2438`	`2438`	`0`
	`2439`	`+lib_manufacturer`
	`2440`	`+1`
	`2441`	`+4`
	`2442`	`+0`
`2439`	`2443`	`library_folder_list`
`2440`	`2444`	`1`
`2441`	`2445`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-931`
	`2`	`+932`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -3211,6 +3211,10 @@ lib_is_bifacial`
`3211`	`3211`	`1`
`3212`	`3212`	`1`
`3213`	`3213`	`0`
	`3214`	`+lib_manufacturer`
	`3215`	`+1`
	`3216`	`+4`
	`3217`	`+0`
`3214`	`3218`	`library_folder_list`
`3215`	`3219`	`1`
`3216`	`3220`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-525`
	`2`	`+526`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -1583,6 +1583,10 @@ lib_is_bifacial`
`1583`	`1583`	`1`
`1584`	`1584`	`1`
`1585`	`1585`	`0`
	`1586`	`+lib_manufacturer`
	`1587`	`+1`
	`1588`	`+4`
	`1589`	`+0`
`1586`	`1590`	`library_folder_list`
`1587`	`1591`	`1`
`1588`	`1592`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-866`
	`2`	`+867`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -3157,6 +3157,10 @@ lib_is_bifacial`
`3157`	`3157`	`1`
`3158`	`3158`	`1`
`3159`	`3159`	`0`
	`3160`	`+lib_manufacturer`
	`3161`	`+1`
	`3162`	`+4`
	`3163`	`+0`
`3160`	`3164`	`library_folder_list`
`3161`	`3165`	`1`
`3162`	`3166`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-839`
	`2`	`+840`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -2937,6 +2937,10 @@ lib_is_bifacial`
`2937`	`2937`	`1`
`2938`	`2938`	`1`
`2939`	`2939`	`0`
	`2940`	`+lib_manufacturer`
	`2941`	`+1`
	`2942`	`+4`
	`2943`	`+0`
`2940`	`2944`	`library_folder_list`
`2941`	`2945`	`1`
`2942`	`2946`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-496`
	`2`	`+497`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -1503,6 +1503,10 @@ lib_is_bifacial`
`1503`	`1503`	`1`
`1504`	`1504`	`1`
`1505`	`1505`	`0`
	`1506`	`+lib_manufacturer`
	`1507`	`+1`
	`1508`	`+4`
	`1509`	`+0`
`1506`	`1510`	`library_folder_list`
`1507`	`1511`	`1`
`1508`	`1512`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`1`
`2`		`-820`
	`2`	`+821`
`3`	`3`	`6par_aisc`
`4`	`4`	`1`
`5`	`5`	`1`
`@@ -2535,6 +2535,10 @@ lib_is_bifacial`
`2535`	`2535`	`1`
`2536`	`2536`	`1`
`2537`	`2537`	`0`
	`2538`	`+lib_manufacturer`
	`2539`	`+1`
	`2540`	`+4`
	`2541`	`+0`
`2538`	`2542`	`library_folder_list`
`2539`	`2543`	`1`
`2540`	`2544`	`4`