Skip to content

Commit 1f373fd

Browse files
committed
Fix findings of AI reviewer
1 parent a433565 commit 1f373fd

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

R/kernelshap.R

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@
2727
#'
2828
#' This is repeated multiple times until convergence, see CL21 for details.
2929
#'
30-
#' To avoid the evaluation of
31-
#' This inefficiency can be fixed by a hybrid strategy, combining exact calculations
32-
#' with sampling.
30+
#' To avoid the re-evaluation of identical coalition vectors, we have implemented
31+
#' a hybrid strategy, combining exact calculations with sampling.
3332
#'
3433
#' The hybrid algorithm has two steps:
3534
#' 1. Step 1 (exact part): There are \eqn{2p} different on-off vectors \eqn{z} with

man/kernelshap.Rd

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test-basic.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ test_that("kernelshap and permshap work for models with high-order interactions"
284284
hybrid_degree = 2,
285285
exact = FALSE,
286286
m = 1000,
287-
max_iter = 100, ,
287+
max_iter = 100,
288288
tol = 0.001,
289289
verbose = FALSE
290290
)

0 commit comments

Comments
 (0)