Improved slug creation

Author: osolmaz

manim_voiceover/helper.py

@@ -17,8 +17,8 @@ def chunks(lst: list, n: int):
         yield lst[i : i + n]
 
 
-def remove_bookmarks(str):
-    return re.sub("<bookmark\s*mark\s*=['\"]\w*[\"']\s*/>", "", str)
+def remove_bookmarks(input: str) -> str:
+    return re.sub("<bookmark\s*mark\s*=['\"]\w*[\"']\s*/>", "", input)
 
 
 def wav2mp3(wav_path, mp3_path=None, remove_wav=True, bitrate="312k"):

manim_voiceover/services/base.py

@@ -11,7 +11,11 @@
     DEFAULT_VOICEOVER_CACHE_DIR,
     DEFAULT_VOICEOVER_CACHE_JSON_FILENAME,
 )
-from manim_voiceover.helper import append_to_json_file, prompt_ask_missing_extras
+from manim_voiceover.helper import (
+    append_to_json_file,
+    prompt_ask_missing_extras,
+    remove_bookmarks,
+)
 from manim_voiceover.modify_audio import adjust_speed
 from manim_voiceover.tracker import AUDIO_OFFSET_RESOLUTION
 
@@ -157,8 +161,9 @@ def get_audio_basename(self, data: dict) -> str:
         dumped_data = json.dumps(data)
         data_hash = hashlib.sha256(dumped_data.encode("utf-8")).hexdigest()
         suffix = data_hash[:8]
-        input_string = data["input_text"]
-        slug = slugify(input_string)
+        input_text = data["input_text"]
+        input_text = remove_bookmarks(input_text)
+        slug = slugify(input_text, max_length=50, word_boundary=True, save_order=True)
         ret = f"{slug}-{suffix}"
         return ret
 

manim_voiceover/services/recorder/__init__.py

@@ -47,9 +47,7 @@ def __init__(
             trim_buffer_start (int, optional): Buffer duration for trimming silence at the start. Defaults to 200 ms.
             trim_buffer_end (int, optional): Buffer duration for trimming silence at the end. Defaults to 200 ms.
         """
-        prompt_ask_missing_extras(
-            ["pyaudio", "pynput"], "recorder", "RecorderService"
-        )
+        prompt_ask_missing_extras(["pyaudio", "pynput"], "recorder", "RecorderService")
 
         self.recorder = Recorder(
             format=format,

manim_voiceover/tracker.py

@@ -87,7 +87,7 @@ def _process_bookmarks(self) -> None:
             )
             self.bookmark_times[mark] = self.start_t + elapsed
 
-    def get_remaining_duration(self, buff: float = 0.) -> float:
+    def get_remaining_duration(self, buff: float = 0.0) -> float:
         """Returns the remaining duration of the voiceover.
 
         Args:

manim_voiceover/translate/render.py

@@ -58,7 +58,6 @@
 
 
 def main():
-
     args = parser.parse_args()
     file = args.file
     domain = args.domain

manim_voiceover/voiceover_scene.py

@@ -8,7 +8,7 @@
 from manim import Scene, config
 from manim_voiceover.services.base import SpeechService
 from manim_voiceover.tracker import VoiceoverTracker
-from manim_voiceover.helper import chunks
+from manim_voiceover.helper import chunks, remove_bookmarks
 
 
 # SCRIPT_FILE_PATH = "media/script.txt"
@@ -72,8 +72,7 @@ def add_voiceover_text(
 
         if self.create_subcaption:
             if subcaption is None:
-                # Remove placeholders
-                subcaption = re.sub(r"<[^<>]+/>", "", text)
+                subcaption = remove_bookmarks(text)
 
             self.add_wrapped_subcaption(
                 subcaption,