feat(users): prevent multi sign up (#8)

* feat(identity): sign-in deny multi register flag

* feat(identity): cleanup

* feat: add tests for deny auth register flow

* Update microservices/users/src/services/identity-provider/abstract.ts

Co-authored-by: Mikhail Yarmaliuk <[email protected]>

* Update microservices/users/src/services/identity-provider/abstract.ts

Co-authored-by: Mikhail Yarmaliuk <[email protected]>

* feat(firebase-test): update name

---------

Co-authored-by: Mikhail Yarmaliuk <[email protected]>

Author: OlegDO

microservices/users/__tests__/services/identity-provider/firebase-test.ts

@@ -100,6 +100,17 @@ describe('services/sign-up', () => {
     expect(await waitResult(service.signIn({ isDenyRegister: true }))).to.throw('User not found.');
   });
 
+  it('should registration throw error: user exist (split sign up/sign in)', async () => {
+    FirebaseSdkStub.resolves(
+      firebaseMock({ user: { email: '[email protected]', emailVerified: true } }),
+    );
+    TypeormMock.queryBuilder.getOne.resolves(mockUser);
+
+    expect(await waitResult(service.signIn({ isDenyAuthViaRegister: true }))).to.throw(
+      'User already exists.',
+    );
+  });
+
   it('should register new user', async () => {
     const email = '[email protected]';
 

microservices/users/src/services/identity-provider/abstract.ts

@@ -12,7 +12,14 @@ export interface ISingInReturn {
   isNew: boolean;
 }
 
-export type TSingInParams = { isDenyRegister?: boolean } & Record<string, any>;
+/**
+ * isDenyRegister - prevent sign in if user exist
+ * isDenyAuthViaRegister - prevent sign in if user exist (split sign up/sign in)
+ */
+export type TSingInParams = { isDenyRegister?: boolean; isDenyAuthViaRegister?: boolean } & Record<
+  string,
+  any
+>;
 
 /**
  * Abstract class for identity providers

microservices/users/src/services/identity-provider/firebase.ts

@@ -17,10 +17,12 @@ class Firebase extends Abstract {
   /**
    * @inheritDoc
    */
-  public async signIn({ isDenyRegister }: TSingInParams = {}): Promise<ISingInReturn> {
+  public async signIn({
+    isDenyRegister,
+    isDenyAuthViaRegister,
+  }: TSingInParams = {}): Promise<ISingInReturn> {
     const [firebaseUser, providerType] = await this.getFirebaseUser();
-    let user = await this.userRepository.findUserByIdentifier(this.provider, firebaseUser.uid);
-    let isNew = false;
+    const user = await this.userRepository.findUserByIdentifier(this.provider, firebaseUser.uid);
 
     if (!user) {
       if (isDenyRegister) {
@@ -30,11 +32,22 @@ class Firebase extends Abstract {
         });
       }
 
-      user = await this.register(firebaseUser, providerType);
-      isNew = true;
+      const userResult = await this.register(firebaseUser, providerType);
+
+      return { user: userResult, isNew: true };
+    }
+
+    if (isDenyAuthViaRegister) {
+      /**
+       * If user registered - error
+       */
+      throw new BaseException({
+        status: 500,
+        message: 'User already exists.',
+      });
     }
 
-    return { user, isNew };
+    return { user, isNew: false };
   }
 
   /**