Skip to content

Commit e494d74

Browse files
authored
Fix links to resolve issue in Builder's Guide (https and redirect)
There are some links in this document that cause issues for pull request [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide Repo.
1 parent edd9ade commit e494d74

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/code_contribution_guidelines.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,15 @@ security and performance implications.
7777

7878
# Required Reading
7979

80-
- [Effective Go](http://golang.org/doc/effective_go.html) - The entire `lnd`
80+
- [Effective Go](https://golang.org/doc/effective_go.html) - The entire `lnd`
8181
project follows the guidelines in this document. For your code to be accepted,
8282
it must follow the guidelines therein.
8383
- [Original Satoshi Whitepaper](https://bitcoin.org/bitcoin.pdf) - This is the white paper that started it all. Having a solid
8484
foundation to build on will make the code much more comprehensible.
8585
- [Lightning Network Whitepaper](https://lightning.network/lightning-network-paper.pdf) - This is the white paper that kicked off the Layer 2 revolution. Having a good grasp of the concepts of Lightning will make the core logic within the daemon much more comprehensible: Bitcoin Script, off-chain blockchain protocols, payment channels, bidirectional payment channels, relative and absolute time-locks, commitment state revocations, and Segregated Witness.
8686
- The original LN was written for a rather narrow audience, the paper may be a bit unapproachable to many. Thanks to the Bitcoin community, there exist many easily accessible supplemental resources which can help one see how all the pieces fit together from double-spend protection all the way up to commitment state transitions and Hash Time Locked Contracts (HTLCs):
8787
- [Lightning Network Summary](https://lightning.network/lightning-network-summary.pdf)
88-
- [Understanding the Lightning Network 3-Part series](https://bitcoinmagazine.com/articles/understanding-the-lightning-network-part-building-a-bidirectional-payment-channel-1464710791)
88+
- [Understanding the Lightning Network 3-Part series](https://bitcoinmagazine.com/technical/understanding-the-lightning-network-part-building-a-bidirectional-payment-channel-1464710791)
8989
- [Deployable Lightning](https://github.com/ElementsProject/lightning/blob/master/doc/miscellaneous/deployable-lightning.pdf)
9090

9191

@@ -140,7 +140,7 @@ code works correctly when it is fed correct data as well as incorrect data
140140

141141
Go provides an excellent test framework that makes writing test code and
142142
checking coverage statistics straightforward. For more information about the
143-
test coverage tools, see the [golang cover blog post](http://blog.golang.org/cover).
143+
test coverage tools, see the [golang cover blog post](https://blog.golang.org/cover).
144144

145145
A quick summary of test practices follows:
146146
- All new code should be accompanied by tests that ensure the code behaves
@@ -168,7 +168,7 @@ extensively using the commands within our `Makefile`. As a result, we recommend
168168
- At a minimum every function must be commented with its intended purpose and
169169
any assumptions that it makes
170170
- Function comments must always begin with the name of the function per
171-
[Effective Go](http://golang.org/doc/effective_go.html)
171+
[Effective Go](https://golang.org/doc/effective_go.html)
172172
- Function comments should be complete sentences since they allow a wide
173173
variety of automated presentations such as [godoc.org](https://godoc.org)
174174
- The general rule of thumb is to look at it as if you were completely

0 commit comments

Comments
 (0)