[0.8.3+0] RC: add arbitrum coin type and private key export (#2512)

* add arbitrum coin type (#166)

* Private Key Export (#183)

* kdf show_priv_key api

* display private keys

* private keys QR code dialog

* private keys list title

* private key dialog width

* private key share instead of copy

* Revert "private key share instead of copy"

This reverts commit a623444ea75e4d074419bcc9689585ca819beceb.

* private key clipboard warning

* DEX Swap form gets filled with URL parameters  (#162)

* router fix uri query parameters were lost at parse

* router add dexroute parameters

* router dex state notifyListeners for new fields

* router dex process order_type param

* router dex clean params without notifying

* router dex maker process ticker and amount params

* router dex fix typo

* dex TakerSetSellCoin event add setOnlyIfNotSet

* router dex maker consumes only their own params

* router dex allow order_type being maker by default

* router dex taker process from/to currencies

* dex repository waitOrderbookAvailability function

* router dex form wait for orderbooks before process

* router dex taker process from_amount

* router dex code cleanup

* mobile/widget layout taker form dropdown position

* maker form parse error check

* hide trading bot setting

* default to wallet route parser if wallet only

* wallet only logout confirmation description

* improve transaction table error message

Use the message suggested by @smk762 rather than printing the raw exception message

* fix disappearing icons on fiat coin selection dropdown

---------

Co-authored-by: Tolga Ay <[email protected]>
Co-authored-by: naezith <[email protected]>

Author: CharlVS

assets/translations/en.json

@@ -193,6 +193,7 @@
     "swapFeeDetailsNone": "None",
     "swapFeeDetailsPaidFromReceivedVolume": "Paid from received volume",
     "logoutPopupTitle": "Confirm log out?",
+    "logoutPopupDescriptionWalletOnly": "Are you sure you want to logout?",
     "logoutPopupDescription": "Are you sure you want to logout? Your opened orders will no longer be available to match with other users and any trades in progress may not be completed",
     "transactionDetailsTitle": "Transaction completed",
     "customSeedWarningText": "Custom seed phrases are generally less secure and easier to crack than a generated BIP39 compliant seed phrase. To confirm you understand and are aware of the risk, type \"I\u00A0Understand\" in the box below.",
@@ -463,6 +464,8 @@
     "manageAnalytics": "Manage analytics",
     "logs": "Logs",
     "resetActivatedCoinsTitle": "Reset Activated Coins",
+    "privateKeys": "Private Keys",
+    "copyWarning": "Your clipboard isn't a safe place for your private key! Copying the seed phrase or private keys can make them vulnerable to clipboard hacks. Please handle with caution and only copy if absolutely necessary.",
     "seedConfirmTitle": "Let's double check your seed phrase",
     "seedConfirmDescription": "Your seed phrase is the only way to access Your funds. That's why we want to ensure you saved it safely. Please input your seed phrase into text filed below.",
     "standardWallet": "Standard wallet",
@@ -513,6 +516,7 @@
     "refreshList": "Refresh {} NFT list",
     "unableRetrieveNftData": "Waiting for {} NFT data sync",
     "tryCheckInternetConnection": "Try checking your internet connection",
+    "connectionToServersFailing": "Connection to {} servers are failing. Please join the Komodo Platform Discord server for support and more information",
     "resetWalletTitle": "Reset Wallet",
     "resetWalletContent": "Do you want to reset activated coins of {} wallet?\n\nResetting the activated coins will revert your wallet to its initial state. You will need to re-enable the coins to include them in your wallet's balance and trade them.",
     "resetCompleteTitle": "Reset Complete",

lib/app_config/app_config.dart

@@ -45,6 +45,7 @@ Map<String, int> priorityCoinsAbbrMap = {
   'DASH': 11,
   'MATIC': 10,
   'FTM': 10,
+  'ARB': 10,
   'AVAX': 10,
   'HT': 10,
   'MOVR': 10,

lib/bloc/dex_repository.dart

@@ -1,4 +1,5 @@
 import 'package:rational/rational.dart';
+import 'package:web_dex/app_config/app_config.dart';
 import 'package:web_dex/mm2/mm2_api/mm2_api.dart';
 import 'package:web_dex/mm2/mm2_api/rpc/base.dart';
 import 'package:web_dex/mm2/mm2_api/rpc/best_orders/best_orders.dart';
@@ -139,4 +140,28 @@ class DexRepository {
 
     return Swap.fromJson(response['result']);
   }
+
+  Future<void> waitOrderbookAvailability({
+    int retries = 10,
+    int interval = 300,
+  }) async {
+    BestOrders orders;
+
+    for (int attempt = 0; attempt < retries; attempt++) {
+      orders = await getBestOrders(
+        BestOrdersRequest(
+          coin: defaultDexCoin,
+          type: BestOrdersRequestType.number,
+          number: 1,
+          action: 'sell',
+        ),
+      );
+
+      if (orders.result?.isNotEmpty ?? false) {
+        return;
+      }
+
+      await Future.delayed(Duration(milliseconds: interval));
+    }
+  }
 }

lib/bloc/fiat/base_fiat_provider.dart

@@ -29,6 +29,7 @@ class Currency {
         (t == CoinType.avx20 && symbol == 'AVAX') ||
         (t == CoinType.etc && symbol == 'ETC') ||
         (t == CoinType.ftm20 && symbol == 'FTM') ||
+        (t == CoinType.arb20 && symbol == 'ARB') ||
         (t == CoinType.hrc20 && symbol == 'ONE') ||
         (t == CoinType.plg20 && symbol == 'MATIC') ||
         (t == CoinType.mvr20 && symbol == 'MOVR')) return symbol;
@@ -155,6 +156,8 @@ abstract class BaseFiatProvider {
         return 'ETC';
       case CoinType.ftm20:
         return 'FTM';
+      case CoinType.arb20:
+        return 'ARB';
       case CoinType.hrc20:
         return 'HARMONY';
       case CoinType.plg20:
@@ -261,6 +264,8 @@ abstract class BaseFiatProvider {
         return CoinType.etc;
       case "FTM":
         return CoinType.ftm20;
+      case "ARB":
+        return CoinType.arb20;
       case "HARMONY":
         return CoinType.hrc20;
       case "MATIC":

lib/bloc/taker_form/taker_bloc.dart

@@ -240,18 +240,18 @@ class TakerBloc extends Bloc<TakerEvent, TakerState> {
     TakerSetDefaults event,
     Emitter<TakerState> emit,
   ) async {
-    if (state.sellCoin == null) await _setDefaultSellCoin();
-  }
-
-  Future<void> _setDefaultSellCoin() async {
-    final Coin? defaultCoin = _coinsRepo.getCoin(defaultDexCoin);
-    add(TakerSetSellCoin(defaultCoin));
+    if (state.sellCoin == null) {
+      final Coin? defaultCoin = _coinsRepo.getCoin(defaultDexCoin);
+      add(TakerSetSellCoin(defaultCoin, setOnlyIfNotSet: true));
+    }
   }
 
   Future<void> _onSetSellCoin(
     TakerSetSellCoin event,
     Emitter<TakerState> emit,
   ) async {
+    if (event.setOnlyIfNotSet && state.sellCoin != null) return;
+
     emit(state.copyWith(
       sellCoin: () => event.coin,
       showCoinSelector: () => false,

lib/bloc/taker_form/taker_event.dart

@@ -25,10 +25,12 @@ class TakerCoinSelectorClick extends TakerEvent {}
 class TakerOrderSelectorClick extends TakerEvent {}
 
 class TakerSetSellCoin extends TakerEvent {
-  TakerSetSellCoin(this.coin, {this.autoSelectOrderAbbr});
+  TakerSetSellCoin(this.coin,
+      {this.autoSelectOrderAbbr, this.setOnlyIfNotSet = false});
 
   final Coin? coin;
   final String? autoSelectOrderAbbr;
+  final bool setOnlyIfNotSet;
 }
 
 class TakerSelectOrder extends TakerEvent {

lib/blocs/maker_form_bloc.dart

@@ -526,7 +526,11 @@ class MakerFormBloc implements BlocBase {
     if (amountStr.isEmpty) {
       amount = null;
     } else {
-      amount = Rational.parse(amountStr);
+      try {
+        amount = Rational.parse(amountStr);
+      } catch (_) {
+        amount = null;
+      }
     }
 
     isMaxActive = false;
@@ -544,7 +548,11 @@ class MakerFormBloc implements BlocBase {
     if (amountStr.isEmpty) {
       amount = null;
     } else {
-      amount = Rational.parse(amountStr);
+      try {
+        amount = Rational.parse(amountStr);
+      } catch (_) {
+        amount = null;
+      }
     }
 
     if (amount == buyAmount) return;