Skip to content

Commit fdc6477

Browse files
authored
Test that we don't accept http urls (#42)
1 parent af0a362 commit fdc6477

File tree

1 file changed

+51
-0
lines changed

1 file changed

+51
-0
lines changed

test/runtests.jl

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,57 @@ end
305305
@test reg == parts[5]
306306
@test key == parts[6]
307307
end
308+
309+
# Only accept https, not http
310+
invalid_azure = [
311+
"http://myaccount.blob.core.windows.net/mycontainer/myblob",
312+
"http://myaccount.blob.core.windows.net/mycontainer",
313+
"http://myaccount",
314+
"HTTP://myaccount.BLOB.core.windows.net/mycontainer/myblob",
315+
"http://myaccount.blob.CORE.windows.net/mycontainer",
316+
"Http://127.0.0.1:45942/myaccount/mycontainer",
317+
"hTTP://127.0.0.1:45942/myaccount/mycontainer/myblob",
318+
]
319+
for url in invalid_azure
320+
ok, host, account, container, blob = CloudStore.parseAzureAccountContainerBlob(url)
321+
@test !ok
322+
end
323+
324+
invalid_s3 = [
325+
"http://bucket-name.s3-accelerate.us-east-1.amazonaws.com/key-name",
326+
"http://bucket-name.s3-accelerate.us-east-1.amazonaws.com",
327+
"http://bucket-name.s3-accelerate.amazonaws.com/key-name",
328+
"http://bucket-name.s3-accelerate.amazonaws.com",
329+
"http://bucket-name.s3.us-east-1.amazonaws.com/key-name",
330+
"http://bucket-name.s3.us-east-1.amazonaws.com",
331+
"http://bucket-name.s3.amazonaws.com/key-name",
332+
"http://bucket-name.s3.amazonaws.com",
333+
"http://s3.us-east-1.amazonaws.com/bucket-name/key-name",
334+
"http://s3.us-east-1.amazonaws.com/bucket-name",
335+
"http://s3.amazonaws.com/bucket-name/key-name",
336+
"http://s3.amazonaws.com/bucket-name",
337+
"http://bucket-name/key-name",
338+
"http://bucket-name",
339+
340+
"Http://bucket-name.s3-ACCELERATE.us-east-1.amazonaws.com/key-name",
341+
"HTTP://bucket-name.s3-accelerate.us-east-1.AMAZONAWS.com",
342+
"http://bucket-name.S3-ACCELERATE.AMAZONAWS.com/key-name",
343+
"hTTP://bucket-name.s3-accelerate.amazonaws.com",
344+
"HTTP://bucket-name.s3.us-east-1.amazonaws.COM/key-name",
345+
"http://bucket-name.S3.us-east-1.AMAZONAWS.COM",
346+
"HTTP://bucket-name.S3.amazonaws.COM/key-name",
347+
"hTTP://bucket-name.S3.AMAZONAWS.COM",
348+
"hTTp://s3.us-east-1.AMAZONAWS.com/bucket-name/key-name",
349+
"HTTP://s3.us-east-1.amazonaws.COM/bucket-name",
350+
"hTTP://S3.AMAZONAWS.COM/bucket-name/key-name",
351+
"httP://S3.AmAzonAws.com/bucket-name",
352+
"httP://bucket-name/key-name",
353+
"httP://bucket-name",
354+
]
355+
for url in invalid_s3
356+
ok, accelerate, host, bucket, reg, key = CloudStore.parseAWSBucketRegionKey(url; parseLocal=true)
357+
@test !ok
358+
end
308359
end
309360

310361
@testset "CloudStore.PrefetchedDownloadStream small readbytes!" begin

0 commit comments

Comments
 (0)