Skip to content

Commit 3e56388

Browse files
committed
Fix tests after upgrading Angular to 1.7
> listen on "change" instead of "click" for radio/checkbox ngModels (656c8f, #4516, #14667, #14685) See https://github.com/angular/angular.js/blob/master/CHANGELOG.md#bug-fixes-2
1 parent ae58ef8 commit 3e56388

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

components/checkbox-ng/checkbox-ng.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import 'dom4';
33
import 'angular';
44
import 'angular-mocks';
55

6-
import sniffer from '../global/sniffer';
7-
86
import Checkbox from './checkbox-ng';
97

108
describe('Checkbox Ng', () => {
@@ -34,13 +32,8 @@ describe('Checkbox Ng', () => {
3432
});
3533

3634
it('should have been set checked by click', () => {
37-
if (sniffer.browser.name === 'ie') {
38-
return;
39-
}
40-
41-
const click = new MouseEvent('click');
42-
// Doesn't trigger handler in IE for some reason
43-
element.query('input').dispatchEvent(click);
35+
element.query('input').dispatchEvent(new MouseEvent('click'));
36+
element.query('input').dispatchEvent(new Event('change'));
4437

4538
iElement.controller('ngModel').$viewValue.should.be.true;
4639
});

components/radio-ng/radio-ng.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import 'dom4';
33
import 'angular';
44
import 'angular-mocks';
55

6-
import sniffer from '../global/sniffer';
7-
86
import Radio from './radio-ng';
97

108
describe('Radio Ng', () => {
@@ -45,13 +43,8 @@ describe('Radio Ng', () => {
4543
});
4644

4745
it('should have been set checked by click', () => {
48-
if (sniffer.browser.name === 'ie') {
49-
return;
50-
}
51-
52-
const click = new MouseEvent('click');
53-
// Doesn't trigger handler in IE for some reason
54-
element.query('input[value=two]').dispatchEvent(click);
46+
element.query('input[value=two]').dispatchEvent(new MouseEvent('click'));
47+
element.query('input[value=two]').dispatchEvent(new Event('change'));
5548

5649
scope.radioModel.should.equal('two');
5750
});

0 commit comments

Comments
 (0)