TypeScript option strict

Author: JeremyJeanson

Distribution/companion/index.js

@@ -7,7 +7,7 @@ import { settingsStorage } from "settings";
 export function initialize(defaultSettings) {
     // Whensettings changed -> send the new value
     settingsStorage.onchange = function (e) {
-        if (e.oldValue !== e.newValue && e.newValue !== undefined) {
+        if (e.key !== null && e.oldValue !== e.newValue && e.newValue !== undefined) {
             sendValue(e.key, e.newValue);
         }
     };
@@ -24,7 +24,7 @@ function sendValue(key, value) {
         var message = {
             type: "setting",
             key: key,
-            value: JSON.parse(value)
+            value: value === null ? "" : JSON.parse(value)
         };
         messaging.peerSocket.send(message);
     }

Distribution/package.json

@@ -1,6 +1,6 @@
 {
   "name": "simple-fitbit-settings",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "Module to simplify management of settings inside Fitbit OS applications",
   "author": "Jérémy Jeanson (https://www.bugshunter.net)",
   "license": "MIT",

Sources/companion/index.ts

@@ -9,7 +9,7 @@ import { MessageData } from "../common";
 export function initialize(defaultSettings: any): void {
   // Whensettings changed -> send the new value
   settingsStorage.onchange = (e) => {
-    if (e.oldValue !== e.newValue && e.newValue !== undefined) {
+    if (e.key !== null && e.oldValue !== e.newValue && e.newValue !== undefined) {
       sendValue(e.key, e.newValue);
     }
   };
@@ -23,12 +23,12 @@ export function initialize(defaultSettings: any): void {
  * @param key of the settings
  * @param value of the settings
  */
-function sendValue(key: string, value: string): void {
+function sendValue(key: string, value: string | null): void {
   if (messaging.peerSocket.readyState === messaging.peerSocket.OPEN) {
     const message: MessageData = {
       type: "setting",
       key: key,
-      value: JSON.parse(value)
+      value: value === null ? "" : JSON.parse(value)
     };
     messaging.peerSocket.send(message);
   } else {
@@ -67,7 +67,7 @@ export function setDefaultSetting(key: string, value: any): void {
  * try to get current setting (return null if not defined or error)
  * @param key 
  */
-function getSetting(key: string): string {
+function getSetting(key: string): string | null {
   try {
     return settingsStorage.getItem(key);
   } catch (ex) {

Sources/package.json

@@ -1,6 +1,6 @@
 {
   "name": "simple-fitbit-settings",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "Module to simplify management of settings inside Fitbit OS applications",
   "author": "Jérémy Jeanson (https://www.bugshunter.net)",
   "license": "MIT",

Sources/tsconfig.json

@@ -1,6 +1,7 @@
 {
 	"extends": "./node_modules/@fitbit/sdk/sdk-tsconfig.json",
 	"compilerOptions": {
+		"strict": true,
 		"noEmit": false,
 		"outDir": "../distribution",
 		"sourceMap": false,