Skip to content

Commit b94e22f

Browse files
committed
perf: simplify subtitle rendering logic and ensure date display consistency across sections
1 parent 4cf7c97 commit b94e22f

File tree

3 files changed

+8
-14
lines changed

3 files changed

+8
-14
lines changed

src/components/preview/CustomSection.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,15 @@ const CustomSection = ({
6767
</h4>
6868
</div>
6969

70-
{centerSubtitle && item.subtitle && (
70+
{centerSubtitle && (
7171
<motion.div layout="position" className="text-subtitleFont">
7272
{item.subtitle}
7373
</motion.div>
7474
)}
7575

76-
{
77-
<span className="text-subtitleFont shrink-0">
78-
{item.dateRange}
79-
</span>
80-
}
76+
<span className="text-subtitleFont shrink-0">
77+
{item.dateRange}
78+
</span>
8179
</motion.div>
8280

8381
{!centerSubtitle && item.subtitle && (

src/components/preview/ExperienceSection.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,12 @@ const ExperienceItem = React.forwardRef<HTMLDivElement, ExperienceItemProps>(
3737
>
3838
{experience.company}
3939
</div>
40-
{experience.position && centerSubtitle && (
40+
{centerSubtitle && (
4141
<motion.div className="text-subtitleFont">
4242
{experience.position}
4343
</motion.div>
4444
)}
45-
{experience.date && (
46-
<div className="text-subtitleFont">{experience.date}</div>
47-
)}
45+
<div className="text-subtitleFont">{experience.date}</div>
4846
</motion.div>
4947
{experience.position && !centerSubtitle && (
5048
<motion.div className="text-subtitleFont">

src/components/preview/ProjectSection.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,12 @@ const ProjectItem = React.forwardRef<HTMLDivElement, ProjectItemProps>(
5151
</a>
5252
)}
5353
</div>
54-
{project.role && globalSettings?.centerSubtitle && (
54+
{globalSettings?.centerSubtitle && (
5555
<motion.div layout="position" className=" text-subtitleFont">
5656
{project.role}
5757
</motion.div>
5858
)}
59-
{project.date && (
60-
<div className="text-subtitleFont">{project.date}</div>
61-
)}
59+
<div className="text-subtitleFont">{project.date}</div>
6260
</motion.div>
6361
{project.role && !centerSubtitle && (
6462
<motion.div layout="position" className=" text-subtitleFont">

0 commit comments

Comments
 (0)