Skip to content

Commit 393a43b

Browse files
haoqixuyurishkuro
authored andcommitted
Fix command in v2 example (jaegertracing#6134)
## Which problem is this PR solving? The `component.UseLocalHostAsDefaultHost` gate has been removed from otel collector since v0.112.0. The example failed to start `jaeger` because of the invalid argument. ## Description of the changes - Remove the invalid command line argument. - Set endpoints for `otlpreceiver` explicitly. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: haoqixu <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Insomniac2904 <[email protected]>
1 parent b8e0683 commit 393a43b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

examples/hotrod/docker-compose-v2.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
services:
55
jaeger:
66
image: ${REGISTRY:-}jaegertracing/jaeger:${JAEGER_VERSION:-latest}
7-
command: ["--feature-gates=-component.UseLocalHostAsDefaultHost"]
7+
command:
8+
- --set=receivers.otlp.protocols.grpc.endpoint="0.0.0.0:4317"
9+
- --set=receivers.otlp.protocols.http.endpoint="0.0.0.0:4318"
810
ports:
911
- "16686:16686"
1012
- "4317:4317"

0 commit comments

Comments
 (0)