Skip to content

Inconsistent use of base_url throughout the code #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrvanes opened this issue Sep 15, 2017 · 0 comments
Open

Inconsistent use of base_url throughout the code #148

mrvanes opened this issue Sep 15, 2017 · 0 comments

Comments

@mrvanes
Copy link
Contributor

mrvanes commented Sep 15, 2017

I tried to map SATOSA to a URI'd path behind a reverse proxy and didn't succeed. Looking through the code there are many mixes of the use of BASE (self.base_url) that defeat using it properly.

  1. metadata (generation) uses it
  2. register_endpoints of saml front and backend modules don't use it, but oidc frontend does
  3. discovery return_url doesn't use it
  4. saml2 backend ACS doesn't

This is where I stopped debugging and fixing the code.

All the above problems can be overcome seperately by wisely choosing a combination of reverse proxy conf (include base path in backend request or not) and SATOSA conf (with or without base path), but never together as as working system. It's a classical waterbed.

This issue is here only to address the problem, because we decided to go vhost based reverse proxy to keep the project going.

To clarify what I mean with base path URI'd SATOSA:
reverse proxy address: https:///satosa/
backend server: http://localhost:8080/ or http://localhost:8080/satosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant