-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
keg_relocate: check for uses_from_macos
when replacing Perl prefix
#20043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: botantony <[email protected]>
Am sort of OK with this if others are but cautiously as it's a bit weird to have the Do we even know that deterministically Linux is always picked with all bottles? It might just be alphabetical and break if a name like Yosemite returns. |
I am not sure what this is. Did you mean that Linux runners do not check bounds (and keg will use the system's prefix even if |
I wasn't talking about
brew/Library/Homebrew/dependencies.rb Line 35 in 317110f
Here's what the tab would output with this: depends_on "perl"All JSON files: {
...
"runtime_dependencies": [
{
"full_name": "perl",
...
"declared_directly": true,
"uses_from_macos": false,
}
],
...
} uses_from_macos "perl"sequoia.json and sonoma.json: {
...
"runtime_dependencies": [],
...
} x86_64_linux.json {
...
"runtime_dependencies": [
{
"full_name": "perl",
...
"declared_directly": true,
"uses_from_macos": true,
}
],
...
} all.json: seems to happen to use x86_64_linux.json uses_from_macos "perl", since: :sequoiasequoia.json: {
...
"runtime_dependencies": [],
...
} sonoma.json and x86_64_linux.json {
...
"runtime_dependencies": [
{
"full_name": "perl",
...
"declared_directly": true,
"uses_from_macos": true,
}
],
...
} all.json: seems to happen to use x86_64_linux.json The last case definitely being incorrect for <= Sonoma if we are checking for In the end it's a fundamental problem with using brew/Library/Homebrew/formula_installer.rb Line 954 in 317110f
|
@botantony please hold off opening any more PRs until the existing ones are merged, thanks |
Agreed. It's also unclear to me how/whether this is
@Bo98 maybe we should just throw it away at either bottle and/or installation time and regenerate it? |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Closes #20023