-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
utils/pypi: ensure pure Python wheels support py3 #19984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This might need to also accept e.g. Technically |
Yeah, technically there are all kinds of compressed and minor version variants here that would be good to handle -- one "good enough" approach would probably be to check that the Python tag is not just This is a good candidate for factoring out more generally, since there's a place in brew/Library/Homebrew/language/python.rb Line 402 in 0e14dd8
|
@woodruffw @Bo98 Does the updated regex of |
Looks pretty good to me, although I think someone could contrive a wheel that incorrectly matches it like so:
(This is technically invalid because In terms of locking it down, my suggestion would be:
|
|
No harm in that, yeah -- technically we should never see that since PyPI would reject |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Supports Homebrew/homebrew-core#224034 . Without this, there's the possibility of picking up a
py2-none-any.whl
when apy3-none-any.whl
is available, eg for https://pypi.org/project/aenum/3.1.16/#files .