Skip to content

Commit 4417f83

Browse files
authored
feat: update cli-utils to v0.31.1 (#3158)
- Replace StatusPoller w/ StatusWatcher. Live commands are now be faster and more responsive. - Remove obsolete --poll-period command option - Replace forked cli-utils with upstream version - Error on Skip, with clear error message, instead of skipping silently - Combine Applied, Changed, Unchanged, and ServersideApplied statuses into one ApplySuccessful status - Use Successful status when there's no diff, and Skipped when apply is filtered, instead of Unchanged for both. - Replace apply/prune/delete Unspecified with Pending - Add Failed status to use when there is an Error (except when Skipped) - Improve readability and consistency of event enum strings - Print event summary at the end of apply/destroy - Modify JSON printer to match new event enums - Fix flaky stdout tests by filtering optional "reconcile pending" output and client-side throttling log messages - Move dependency versions to have them hardcoded in a single location - Improve accuracy of e2e bash tests
1 parent 968ba75 commit 4417f83

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+865
-8158
lines changed

.github/workflows/verifyContent.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
make build
3737
- name: Get dependencies
3838
run: |
39-
go install github.com/monopole/mdrip@latest
40-
go install sigs.k8s.io/kind@v0.13.0
39+
make install-mdrip
40+
make install-kind
4141
- name: Verify Examples
4242
run: make site-verify-examples

Makefile

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,30 @@ update-deps-to-head:
3939
go get sigs.k8s.io/cli-utils@master
4040
go get sigs.k8s.io/kustomize/kyaml@master
4141

42+
.PHONY: install-mdrip
43+
install-mdrip:
44+
go install github.com/monopole/[email protected]
45+
46+
.PHONY: install-kind
47+
install-kind:
48+
go install sigs.k8s.io/[email protected]
49+
50+
.PHONY: install-golangci-lint
51+
install-golangci-lint:
52+
go install github.com/golangci/golangci-lint/cmd/[email protected]
53+
54+
.PHONY: install-go-licenses
55+
install-go-licenses:
56+
go install github.com/google/[email protected]
57+
58+
.PHONY: install-swagger
59+
install-swagger:
60+
go install github.com/go-swagger/go-swagger/cmd/[email protected]
61+
62+
.PHONY: install-mdtogo
63+
install-mdtogo:
64+
go install ./mdtogo
65+
4266
fix:
4367
go fix ./...
4468

@@ -48,8 +72,7 @@ fmt:
4872
schema:
4973
GOBIN=$(GOBIN) scripts/generate-schema.sh
5074

51-
generate:
52-
go install ./mdtogo
75+
generate: install-mdtogo
5376
rm -rf internal/docs/generated
5477
mkdir internal/docs/generated
5578
GOBIN=$(GOBIN) go generate ./...
@@ -61,12 +84,10 @@ tidy:
6184
license:
6285
scripts/update-license.sh
6386

64-
lint:
65-
go install github.com/golangci/golangci-lint/cmd/[email protected]
87+
lint: install-golangci-lint
6688
$(GOBIN)/golangci-lint run ./...
6789

68-
license-check:
69-
(which go-licenses || go install github.com/google/go-licenses@latest)
90+
license-check: install-go-licenses
7091
$(GOBIN)/go-licenses check github.com/GoogleContainerTools/kpt
7192

7293
test:
@@ -122,5 +143,5 @@ site-check:
122143
make site-run-server
123144
./scripts/check-site.sh
124145

125-
site-verify-examples:
146+
site-verify-examples: install-mdrip install-kind
126147
./scripts/verifyExamples.sh

demos/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ Requires:
66

77
- `git`
88
- [kpt](https://github.com/GoogleContainerTools/kpt)
9-
- `go get -v github.com/GoogleContainerTools/kpt`
9+
- `go install -v github.com/GoogleContainerTools/kpt`

0 commit comments

Comments
 (0)