don't check file permissions if file doesn't exist (#199)

nkubala · web-flow · commit 8021dc1bd7d9 · 2019-02-19T12:50:23.000-08:00
diff --git a/pkg/types/v1/file_existence.go b/pkg/types/v1/file_existence.go
@@ -86,7 +86,7 @@ func (ft FileExistenceTest) Run(driver drivers.Driver) *types.TestResult {
 		result.Errorf("File %s should not exist but does", ft.Path)
 		result.Fail()
 	}
-	if ft.Permissions != "" {
+	if ft.Permissions != "" && info != nil {
 		perms := info.Mode()
 		if perms.String() != ft.Permissions {
 			result.Errorf("%s has incorrect permissions. Expected: %s, Actual: %s", ft.Path, ft.Permissions, perms.String())
diff --git a/pkg/types/v2/file_existence.go b/pkg/types/v2/file_existence.go
@@ -105,7 +105,7 @@ func (ft FileExistenceTest) Run(driver drivers.Driver) *types.TestResult {
 		result.Errorf("File %s should not exist but does", ft.Path)
 		result.Fail()
 	}
-	if ft.Permissions != "" {
+	if ft.Permissions != "" && info != nil {
 		perms := info.Mode()
 		if perms.String() != ft.Permissions {
 			result.Errorf("%s has incorrect permissions. Expected: %s, Actual: %s", ft.Path, ft.Permissions, perms.String())

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func (ft FileExistenceTest) Run(driver drivers.Driver) *types.TestResult {`
`86`	`86`	`result.Errorf("File %s should not exist but does", ft.Path)`
`87`	`87`	`result.Fail()`
`88`	`88`	`}`
`89`		`- if ft.Permissions != "" {`
	`89`	`+ if ft.Permissions != "" && info != nil {`
`90`	`90`	`perms := info.Mode()`
`91`	`91`	`if perms.String() != ft.Permissions {`
`92`	`92`	`result.Errorf("%s has incorrect permissions. Expected: %s, Actual: %s", ft.Path, ft.Permissions, perms.String())`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ func (ft FileExistenceTest) Run(driver drivers.Driver) *types.TestResult {`
`105`	`105`	`result.Errorf("File %s should not exist but does", ft.Path)`
`106`	`106`	`result.Fail()`
`107`	`107`	`}`
`108`		`- if ft.Permissions != "" {`
	`108`	`+ if ft.Permissions != "" && info != nil {`
`109`	`109`	`perms := info.Mode()`
`110`	`110`	`if perms.String() != ft.Permissions {`
`111`	`111`	`result.Errorf("%s has incorrect permissions. Expected: %s, Actual: %s", ft.Path, ft.Permissions, perms.String())`