Skip to content

Commit f7ee365

Browse files
committed
Clarify skipped "Install packages (Ubuntu)" step
- Slightly reword and reformat the block comment. - Run two commands instead of using `&&`, since with `shell: bash` (inherited as the default as specified at the workflow level), the actual shell command invoked for script steps includes `-e`, so the script would still immediately fail if the first command fails.
1 parent b84162d commit f7ee365

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,13 @@ jobs:
174174
uses: actions/checkout@v4
175175

176176
- name: Install packages (Ubuntu)
177-
# Because openssl doesn't work on musl by default, we resort to max-pure. And that won't need any dependency, so we can skip this.continue-on-error
177+
# Because openssl doesn't work on musl by default, we resort to max-pure.
178+
# And that won't need any dependency, so we can skip this or use `continue-on-error`.
178179
# Once we want to support better zlib performance, we might have to re-add it.
179180
if: matrix.os == 'ubuntu-latest-disabled'
180181
run: |
181-
sudo apt-get update && sudo apt-get install -y --no-install-recommends xz-utils liblz4-tool musl-tools
182+
sudo apt-get update
183+
sudo apt-get install -y --no-install-recommends xz-utils liblz4-tool musl-tools
182184
183185
- name: Install Rust
184186
uses: dtolnay/rust-toolchain@master

0 commit comments

Comments
 (0)