Skip to content

Commit 97c9e84

Browse files
authored
chore: drop go1.16 (#233)
1 parent feff6a0 commit 97c9e84

File tree

5 files changed

+40
-34
lines changed

5 files changed

+40
-34
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
- master
66
pull_request:
77

8-
concurrency:
8+
concurrency:
99
group: ${{ github.workflow }}-${{ github.head_ref }}
1010
cancel-in-progress: true
1111

@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
max-parallel: 1
1818
matrix:
19-
goVer: ["1.16", "1.17", "1.18"]
19+
goVer: ['1.17', '1.18']
2020
steps:
2121
- uses: actions/checkout@v3
2222

.github/workflows/reviewdog.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,12 @@ jobs:
2020
- name: Setup Go
2121
uses: actions/setup-go@v3
2222
with:
23-
go-version: "^1.17.0"
23+
go-version: '1.17'
2424

2525
- name: Install golangci-lint
26-
run:
27-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.44.0
26+
run: make install-golangci
2827

2928
- name: Reviewdog
3029
env:
3130
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
32-
run:
33-
$(go env GOPATH)/bin/golangci-lint run --out-format line-number | reviewdog -f=golangci-lint -name=golangci-lint -reporter=github-pr-review
31+
run: $(go env GOPATH)/bin/golangci-lint run --out-format line-number | reviewdog -f=golangci-lint -name=golangci-lint -reporter=github-pr-review

.golangci.yml

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ linters-settings:
2121
- style
2222
settings:
2323
hugeParam:
24-
sizeThreshold: 377
24+
sizeThreshold: 512
2525
rangeValCopy:
2626
sizeThreshold: 364
2727
skipTestFuncs: true
@@ -38,36 +38,39 @@ run:
3838
linters:
3939
enable-all: true
4040
disable:
41-
- wrapcheck
42-
- varnamelen
43-
- thelper
44-
- tagliatelle
45-
- paralleltest
46-
- nlreturn
47-
- exhaustivestruct
48-
- wsl
49-
- goerr113
50-
- golint
51-
- gochecknoglobals
52-
- scopelint
53-
- funlen
54-
- lll
55-
- maligned
56-
- gomnd
57-
- godox
58-
- interfacer
41+
- contextcheck
42+
- exhaustivestruct
43+
- exhaustruct
44+
- funlen
45+
- gochecknoglobals
46+
- godox
47+
- goerr113
48+
- golint
49+
- gomnd
50+
- interfacer
51+
- lll
52+
- maligned
53+
- nlreturn
54+
- nonamedreturns
55+
- paralleltest
56+
- scopelint
57+
- tagliatelle
58+
- thelper
59+
- varnamelen
60+
- wrapcheck
61+
- wsl
5962
issues:
6063
exclude-rules:
6164
- linters:
6265
- stylecheck
63-
text: "ST1003:" # should not use underscores in package names
66+
text: 'ST1003:' # should not use underscores in package names
6467
- linters:
6568
- revive
6669
text: "don't use an underscore in package name"
6770
- linters:
68-
- gocritic
69-
text: "commentFormatting"
71+
- gocritic
72+
text: 'commentFormatting'
7073
- path: _test\.go
7174
linters:
72-
- gosec
73-
- testpackage # makes you use a separate _test package
75+
- gosec
76+
- testpackage # makes you use a separate _test package

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
GOLANGCI_VERSION = 1.44.0
1+
GOLANGCI_VERSION = 1.46.2
22
GOLANGCI = vendor/golangci-lint/$(GOLANGCI_VERSION)/golangci-lint
33

44
install-golangci:

go.mod

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
module github.com/GetStream/stream-chat-go/v5
22

3-
go 1.16
3+
go 1.17
44

55
require (
6-
github.com/davecgh/go-spew v1.1.1 // indirect
76
github.com/golang-jwt/jwt/v4 v4.0.0
87
github.com/stretchr/testify v1.7.0
98
)
9+
10+
require (
11+
github.com/davecgh/go-spew v1.1.1 // indirect
12+
github.com/pmezard/go-difflib v1.0.0 // indirect
13+
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect
14+
)

0 commit comments

Comments
 (0)