Prevent percentage memory calculation from overflowing (#73)

bscout9956 · web-flow · commit 18b95636972d · 2024-11-10T17:28:21.000+03:00
diff --git a/src/limits/Misc/MemoryAvailable.cpp b/src/limits/Misc/MemoryAvailable.cpp
@@ -23,7 +23,8 @@ struct MemoryLimit : public SimpleAdjuster
             MEMORYSTATUSEX sysmem = { sizeof(sysmem) };
             if(GlobalMemoryStatusEx(&sysmem))
             {
-                memory = uint32_t(sysmem.ullTotalPhys * std::stoul(value.substr(0, value.size() - 1)) / 100);
+                auto calcmem = sysmem.ullTotalPhys * (std::stoul(value.substr(0, value.size() - 1)) / 100.0);
+                memory = calcmem > UINT32_MAX ? UINT32_MAX : uint32_t(calcmem); // use the maximum value of uint32_t (if the calculated value exceeds the capacity)
             }
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ struct MemoryLimit : public SimpleAdjuster`
`23`	`23`	`MEMORYSTATUSEX sysmem = { sizeof(sysmem) };`
`24`	`24`	`if(GlobalMemoryStatusEx(&sysmem))`
`25`	`25`	`{`
`26`		`- memory = uint32_t(sysmem.ullTotalPhys * std::stoul(value.substr(0, value.size() - 1)) / 100);`
	`26`	`+ auto calcmem = sysmem.ullTotalPhys * (std::stoul(value.substr(0, value.size() - 1)) / 100.0);`
	`27`	`+ memory = calcmem > UINT32_MAX ? UINT32_MAX : uint32_t(calcmem); // use the maximum value of uint32_t (if the calculated value exceeds the capacity)`
`27`	`28`	`}`
`28`	`29`	`}`
`29`	`30`	`else`