release: 8.3.2 (#481)

* chore(client): refactor closing / shutdown

* chore(internal): support running ktfmt directly

* release: 8.3.2

---------

Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>

Author: stainless-app[bot]

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "8.3.1"
+  ".": "8.3.2"
 }

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 8.3.2 (2025-08-20)
+
+Full Changelog: [v8.3.1...v8.3.2](https://github.com/Finch-API/finch-api-kotlin/compare/v8.3.1...v8.3.2)
+
+### Chores
+
+* **client:** refactor closing / shutdown ([b8eab02](https://github.com/Finch-API/finch-api-kotlin/commit/b8eab023ed3e81a9c16de1205f2e8075c4f0cb40))
+* **internal:** support running ktfmt directly ([192c9eb](https://github.com/Finch-API/finch-api-kotlin/commit/192c9ebb042f49b7294d0c706049827ed30c2dae))
+
 ## 8.3.1 (2025-08-14)
 
 Full Changelog: [v8.3.0...v8.3.1](https://github.com/Finch-API/finch-api-kotlin/compare/v8.3.0...v8.3.1)

README.md

@@ -2,8 +2,8 @@
 
 <!-- x-release-please-start-version -->
 
-[![Maven Central](https://img.shields.io/maven-central/v/com.tryfinch.api/finch-kotlin)](https://central.sonatype.com/artifact/com.tryfinch.api/finch-kotlin/8.3.1)
-[![javadoc](https://javadoc.io/badge2/com.tryfinch.api/finch-kotlin/8.3.1/javadoc.svg)](https://javadoc.io/doc/com.tryfinch.api/finch-kotlin/8.3.1)
+[![Maven Central](https://img.shields.io/maven-central/v/com.tryfinch.api/finch-kotlin)](https://central.sonatype.com/artifact/com.tryfinch.api/finch-kotlin/8.3.2)
+[![javadoc](https://javadoc.io/badge2/com.tryfinch.api/finch-kotlin/8.3.2/javadoc.svg)](https://javadoc.io/doc/com.tryfinch.api/finch-kotlin/8.3.2)
 
 <!-- x-release-please-end -->
 
@@ -15,7 +15,7 @@ It is generated with [Stainless](https://www.stainless.com/).
 
 <!-- x-release-please-start-version -->
 
-The REST API documentation can be found on [developer.tryfinch.com](https://developer.tryfinch.com/). KDocs are available on [javadoc.io](https://javadoc.io/doc/com.tryfinch.api/finch-kotlin/8.3.1).
+The REST API documentation can be found on [developer.tryfinch.com](https://developer.tryfinch.com/). KDocs are available on [javadoc.io](https://javadoc.io/doc/com.tryfinch.api/finch-kotlin/8.3.2).
 
 <!-- x-release-please-end -->
 
@@ -26,7 +26,7 @@ The REST API documentation can be found on [developer.tryfinch.com](https://deve
 ### Gradle
 
 ```kotlin
-implementation("com.tryfinch.api:finch-kotlin:8.3.1")
+implementation("com.tryfinch.api:finch-kotlin:8.3.2")
 ```
 
 ### Maven
@@ -35,7 +35,7 @@ implementation("com.tryfinch.api:finch-kotlin:8.3.1")
 <dependency>
   <groupId>com.tryfinch.api</groupId>
   <artifactId>finch-kotlin</artifactId>
-  <version>8.3.1</version>
+  <version>8.3.2</version>
 </dependency>
 ```
 

build.gradle.kts

@@ -8,7 +8,7 @@ repositories {
 
 allprojects {
     group = "com.tryfinch.api"
-    version = "8.3.1" // x-release-please-version
+    version = "8.3.2" // x-release-please-version
 }
 
 subprojects {

finch-kotlin-core/src/main/kotlin/com/tryfinch/api/client/FinchClientAsyncImpl.kt

@@ -121,7 +121,7 @@ class FinchClientAsyncImpl(private val clientOptions: ClientOptions) : FinchClie
 
     override fun connect(): ConnectServiceAsync = connect
 
-    override fun close() = clientOptions.httpClient.close()
+    override fun close() = clientOptions.close()
 
     // Auth helpers:
     /** @deprecated use client.accessTokens().create instead */

finch-kotlin-core/src/main/kotlin/com/tryfinch/api/client/FinchClientImpl.kt

@@ -111,7 +111,7 @@ class FinchClientImpl(private val clientOptions: ClientOptions) : FinchClient {
 
     override fun connect(): ConnectService = connect
 
-    override fun close() = clientOptions.httpClient.close()
+    override fun close() = clientOptions.close()
 
     // auth helpers:
     /** @deprecated use client.accessTokens().create instead */

finch-kotlin-core/src/main/kotlin/com/tryfinch/api/core/ClientOptions.kt

@@ -20,6 +20,8 @@ private constructor(
      * The HTTP client to use in the SDK.
      *
      * Use the one published in `finch-kotlin-client-okhttp` or implement your own.
+     *
+     * This class takes ownership of the client and closes it when closed.
      */
     val httpClient: HttpClient,
     /**
@@ -162,6 +164,8 @@ private constructor(
          * The HTTP client to use in the SDK.
          *
          * Use the one published in `finch-kotlin-client-okhttp` or implement your own.
+         *
+         * This class takes ownership of the client and closes it when closed.
          */
         fun httpClient(httpClient: HttpClient) = apply {
             this.httpClient = PhantomReachableClosingHttpClient(httpClient)
@@ -429,4 +433,18 @@ private constructor(
             )
         }
     }
+
+    /**
+     * Closes these client options, relinquishing any underlying resources.
+     *
+     * This is purposefully not inherited from [AutoCloseable] because the client options are
+     * long-lived and usually should not be synchronously closed via try-with-resources.
+     *
+     * It's also usually not necessary to call this method at all. the default client automatically
+     * releases threads and connections if they remain idle, but if you are writing an application
+     * that needs to aggressively release unused resources, then you may call this method.
+     */
+    fun close() {
+        httpClient.close()
+    }
 }

finch-kotlin-core/src/main/kotlin/com/tryfinch/api/core/PhantomReachableExecutorService.kt

@@ -0,0 +1,58 @@
+package com.tryfinch.api.core
+
+import java.util.concurrent.Callable
+import java.util.concurrent.ExecutorService
+import java.util.concurrent.Future
+import java.util.concurrent.TimeUnit
+
+/**
+ * A delegating wrapper around an [ExecutorService] that shuts it down once it's only phantom
+ * reachable.
+ *
+ * This class ensures the [ExecutorService] is shut down even if the user forgets to do it.
+ */
+internal class PhantomReachableExecutorService(private val executorService: ExecutorService) :
+    ExecutorService {
+    init {
+        closeWhenPhantomReachable(this) { executorService.shutdown() }
+    }
+
+    override fun execute(command: Runnable) = executorService.execute(command)
+
+    override fun shutdown() = executorService.shutdown()
+
+    override fun shutdownNow(): MutableList<Runnable> = executorService.shutdownNow()
+
+    override fun isShutdown(): Boolean = executorService.isShutdown
+
+    override fun isTerminated(): Boolean = executorService.isTerminated
+
+    override fun awaitTermination(timeout: Long, unit: TimeUnit): Boolean =
+        executorService.awaitTermination(timeout, unit)
+
+    override fun <T : Any?> submit(task: Callable<T>): Future<T> = executorService.submit(task)
+
+    override fun <T : Any?> submit(task: Runnable, result: T): Future<T> =
+        executorService.submit(task, result)
+
+    override fun submit(task: Runnable): Future<*> = executorService.submit(task)
+
+    override fun <T : Any?> invokeAll(
+        tasks: MutableCollection<out Callable<T>>
+    ): MutableList<Future<T>> = executorService.invokeAll(tasks)
+
+    override fun <T : Any?> invokeAll(
+        tasks: MutableCollection<out Callable<T>>,
+        timeout: Long,
+        unit: TimeUnit,
+    ): MutableList<Future<T>> = executorService.invokeAll(tasks, timeout, unit)
+
+    override fun <T : Any?> invokeAny(tasks: MutableCollection<out Callable<T>>): T =
+        executorService.invokeAny(tasks)
+
+    override fun <T : Any?> invokeAny(
+        tasks: MutableCollection<out Callable<T>>,
+        timeout: Long,
+        unit: TimeUnit,
+    ): T = executorService.invokeAny(tasks, timeout, unit)
+}

scripts/format

@@ -4,5 +4,10 @@ set -e
 
 cd "$(dirname "$0")/.."
 
-echo "==> Running formatters"
-./gradlew format
+if command -v ktfmt &> /dev/null; then
+    echo "==> Running ktfmt"
+    find . -name "*.kt" -not -path "./buildSrc/build/*" -print0 | xargs -0 -r ktfmt --kotlinlang-style "$@"
+else
+    echo "==> Running gradlew format"
+    ./gradlew format
+fi

scripts/lint

@@ -4,5 +4,10 @@ set -e
 
 cd "$(dirname "$0")/.."
 
-echo "==> Running lints"
-./gradlew lint
+if command -v ktfmt &> /dev/null; then
+    echo "==> Checking ktfmt"
+    ./scripts/format --dry-run --set-exit-if-changed
+else
+    echo "==> Running gradlew lint"
+    ./gradlew lint
+fi