Skip to content

Commit e79dc4a

Browse files
wgreenbergcooperq
authored andcommitted
lib: diable null-cipher heuristic due to false positives
Due to an upstream hampi bug (ystero-dev/hampi#133), our RRC parser is reporting false-positives for the null cipher heuristic.
1 parent 6204bc0 commit e79dc4a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/src/analysis/analyzer.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,11 @@ impl Harness {
121121
harness.add_analyzer(Box::new(ImsiRequestedAnalyzer::new()));
122122
harness.add_analyzer(Box::new(ConnectionRedirect2GDowngradeAnalyzer{}));
123123
harness.add_analyzer(Box::new(LteSib6And7DowngradeAnalyzer{}));
124-
harness.add_analyzer(Box::new(NullCipherAnalyzer{}));
124+
125+
// FIXME: our RRC parser is reporting false positives for this due to an
126+
// upstream hampi bug (https://github.com/ystero-dev/hampi/issues/133).
127+
// once that's fixed, we should regenerate our parser and re-enable this
128+
// harness.add_analyzer(Box::new(NullCipherAnalyzer{}));
125129

126130
harness
127131
}

0 commit comments

Comments
 (0)