Skip to content

Commit 1777ac0

Browse files
authored
fix: result page is now hidden until user clicks on get result (#176)
result page is hidden until user clicks on get result, this is managed with CSS property 'display'. It usually remains 'none' and becames 'flex' when user clicks on get result button. fix #168
1 parent aacfd50 commit 1777ac0

File tree

8 files changed

+23
-2
lines changed

8 files changed

+23
-2
lines changed

src/lib/general.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,9 @@ export function triggerEmptyAnimation(inputElement: HTMLInputElement): void {
125125
}, 1000);
126126
}
127127

128+
export const getResultPage = (): HTMLElement =>
129+
<HTMLElement>document.querySelector('.side-results');
130+
128131
export const getCopyCodeButton = (attribute: string): HTMLElement =>
129132
<HTMLElement>document.querySelector(`[data-download = ${attribute}-code]`);
130133

src/main.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ function showResult(attribute: string | null) {
250250

251251
generators.forEach((generator) => {
252252
generator?.addEventListener('click', (): void => {
253-
sidebar.style.left = '100%';
253+
sidebar.style.display = 'none';
254254
const checking = generator.getAttribute('data-gen');
255255
if (checking === 'gradient-border') {
256256
generatorsFunction(checking);
@@ -278,6 +278,9 @@ closeBar?.addEventListener('click', () => {
278278
sidebar.animate(sideBarSlide, sideBarTiming);
279279
sidebar.style.left = '100%';
280280
showResult(null);
281+
setTimeout(() => {
282+
sidebar.style.display = 'none'
283+
}, 600);
281284
});
282285

283286
for (let i = 0; i < gradientBackgroundInputs.length; i++) {

src/pages/animation.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ export function animationGenerator() {
2121

2222
const Stylesheet = utils.getStyleSheet();
2323
const getCodeButtonElement = utils.getCopyCodeButton(attribute);
24+
const resultPage = utils.getResultPage();
25+
26+
resultPage.style.display = 'flex';
27+
2428
initial_length = Stylesheet.cssRules.length - 1;
2529

2630
initialConfiguration(radio_button_set, DegreeElement, OutputElement);

src/pages/gradient-background.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ export function gradientBackgroundGenerator() {
1414
const getDegreeElement = utils.getRange(attribute);
1515

1616
const getOutputElement = utils.getOutput(attribute);
17+
const resultPage = utils.getResultPage();
18+
19+
resultPage.style.display = 'flex';
1720

1821
const values: Values = {
1922
firstColor: color1.value,

src/pages/gradient-border.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ export function gradientBorderGenerator(): void {
1717
const getBorderRadiusInput = utils.getRadiusInput(attribute);
1818
const showRadiusInput = utils.showRadius;
1919
const hideRadiusInput = utils.hideRadius;
20+
const resultPage = utils.getResultPage();
21+
22+
resultPage.style.display = 'flex';
2023

2124
getCheckboxElement.addEventListener('change', (e: Event): void => {
2225
const target = e.target as HTMLInputElement;

src/pages/gradient-text.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ export function gradientTextGenerator(): void {
1010
const attribute = 'gradient-text';
1111
const getInputElement = utils.getInputText(attribute);
1212
const getOutputElement = utils.getOutput(attribute);
13+
const resultPage = utils.getResultPage();
14+
15+
resultPage.style.display = 'flex';
1316
if (getOutputElement === null) return;
1417
getOutputElement.style.display = 'grid';
1518
getOutputElement.style.placeItems = 'center';

src/pages/pic-text.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import * as utils from '../lib/general';
77
export function picTextGenerator(image: string, imageHeight: number): void {
88
const attribute = 'pic-text';
99
const outputNode = utils.getOutput(attribute);
10+
const resultPage = utils.getResultPage();
1011

1112
// The value 19 is the result I got by dividing the height of the image by
1213
// the number of lines of text necessary to cover its full height.
@@ -16,6 +17,7 @@ export function picTextGenerator(image: string, imageHeight: number): void {
1617
Math.ceil(imageHeight / 19)
1718
);
1819

20+
resultPage.style.display = 'flex';
1921
outputNode.style.background = `url(${image}) center no-repeat`;
2022
outputNode.style.width = 'var(--output-width)';
2123
outputNode.style.height = `${imageHeight}px`;

src/style.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ textarea {
300300

301301
/* Results */
302302
.side-results {
303-
display: flex;
303+
display: none;
304304
background-color: var(--secondary-color);
305305
min-height: var(--content-container);
306306
min-width: var(--content-container);

0 commit comments

Comments
 (0)