Skip to content

Commit 9a7af89

Browse files
committed
MSVC is more strict on implicit type cast
Converting `node_api_nogc_finalize` to `napi_finalize` requires a reinterpret_cast in MSVC.
1 parent be2f671 commit 9a7af89

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/js_native_api_v8.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3133,7 +3133,7 @@ napi_create_external_arraybuffer(napi_env env,
31333133
buffer,
31343134
0,
31353135
v8impl::Ownership::kRuntime,
3136-
finalize_cb,
3136+
reinterpret_cast<napi_finalize>(finalize_cb),
31373137
external_data,
31383138
finalize_hint);
31393139
}

0 commit comments

Comments
 (0)