Skip to content

Commit e95cdf1

Browse files
mergify[bot]Julien Danjou
andauthored
fix(gevent): don't forget to call activate hooks on span activation (#2605) (#2607)
(cherry picked from commit 232fc4a) Co-authored-by: Julien Danjou <[email protected]>
1 parent 72e00b3 commit e95cdf1

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

ddtrace/contrib/gevent/provider.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def activate(self, context):
3030
current_g = gevent.getcurrent()
3131
if current_g is not None:
3232
setattr(current_g, self._CONTEXT_ATTR, context)
33+
super(GeventContextProvider, self).activate(context)
3334
return context
3435

3536
def active(self):

tests/contrib/gevent/test_provider.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
from ddtrace.contrib.gevent import provider
2+
3+
4+
def test_call_hooks(tracer):
5+
data = {}
6+
7+
def record(context):
8+
if "trace" not in data:
9+
data["trace"] = context
10+
11+
tracer.configure(context_provider=provider.GeventContextProvider())
12+
tracer.context_provider._on_activate(record)
13+
with tracer.trace("test123") as mytrace:
14+
pass
15+
assert data["trace"] is mytrace

0 commit comments

Comments
 (0)