AWS backup (#15)

* Adding backup feature

* Removing efs-backup file

* Cleaning up variables

* Fixing code format

* Adding variable description

Author: lzrocha

_variables.tf

@@ -130,11 +130,6 @@ variable "alarm_efs_credits_low_threshold" {
   default     = 1000000000000
 }
 
-variable "expire_backup_efs" {
-  default     = 0
-  description = "Number of days the backup will be expired"
-}
-
 variable "target_group_arns" {
   default     = []
   type        = list(string)
@@ -188,3 +183,9 @@ variable "schedule_cron_stop" {
   default     = ""
   description = "Cron expression to define when to trigger a stop of the auto-scaling group. E.g. '0 10 * * *' to stop at 10am GMT time"
 }
+
+variable "backup" {
+  type        = string
+  default     = "true"
+  description = "Assing a backup tag to efs resource - Backup will be performed by AWS Backup"
+}

cloutwatch-alarms-alb.tf

@@ -43,8 +43,8 @@ resource "aws_cloudwatch_metric_alarm" "alb_400_errors" {
 }
 
 resource "aws_cloudwatch_metric_alarm" "alb_latency" {
-  count = var.alb && length(var.alarm_sns_topics) > 0 && var.alarm_alb_latency_anomaly_threshold > 0 ? 1 : 0
-  alarm_name                = "${data.aws_iam_account_alias.current.account_alias}-ecs-${var.name}-alb-latency"
+  count      = var.alb && length(var.alarm_sns_topics) > 0 && var.alarm_alb_latency_anomaly_threshold > 0 ? 1 : 0
+  alarm_name = "${data.aws_iam_account_alias.current.account_alias}-ecs-${var.name}-alb-latency"
   # alarm_name                = "${data.aws_iam_account_alias.current.account_alias}-ecs-${var.name}-latency"
   comparison_operator       = "GreaterThanUpperThreshold"
   evaluation_periods        = "2"

efs-backup.tf

@@ -3,7 +3,8 @@ resource "aws_efs_file_system" "ecs" {
   encrypted      = true
 
   tags = {
-    Name = "ecs-${var.name}"
+    Name   = "ecs-${var.name}"
+    Backup = var.backup
   }
 
   # lifecycle {