fix(coverity): Fix coverity reported bugs

Fixes #682

Author: howjmay

accelerator/core/apis.c

@@ -193,7 +193,7 @@ status_t api_recv_mam_message(const iota_config_t* const iconf, const iota_clien
   if (!req || !res) {
     ret = SC_OOM;
     ta_log_error("%s\n", ta_error_to_string(ret));
-    return ret;
+    goto done;
   }
 
   ret = recv_mam_message_req_deserialize(obj, req);

accelerator/core/core.c

@@ -481,6 +481,7 @@ status_t ta_get_bundles_by_addr(const iota_client_service_t* const service, tryt
       ret = ta_get_bundle(service, bundle_hash, bundle);
       if (ret != SC_OK) {
         ta_log_error("%s\n", ta_error_to_string(ret));
+        bundle_transactions_free(&bundle);
         goto done;
       }
 
@@ -542,7 +543,8 @@ status_t ta_update_node_connection(ta_config_t* const ta_conf, iota_client_servi
   status_t ret = SC_OK;
   for (int i = 0; i < MAX_NODE_LIST_ELEMENTS && ta_conf->iota_host_list[i]; i++) {
     // update new IOTA full node
-    strncpy(service->http.host, ta_conf->iota_host_list[i], HOST_MAX_LEN);
+    strncpy(service->http.host, ta_conf->iota_host_list[i], HOST_MAX_LEN - 1);
+    service->http.host[HOST_MAX_LEN - 1] = '\0';
     service->http.port = ta_conf->iota_port_list[i];
     ta_log_info("Try to connect to %s:%d\n", service->http.host, service->http.port);
 

accelerator/core/mam_core.c

@@ -334,6 +334,10 @@ static bool is_setting_changed(const iota_client_service_t *const service, mam_a
   bool changed = true;
   find_transactions_req_t *txn_req = find_transactions_req_new();
   transaction_array_t *txn_res = transaction_array_new();
+  if (!txn_req || !txn_res) {
+    ta_log_error("%s\n", ta_error_to_string(SC_OOM));
+    goto done;
+  }
 
   if (mam_api_channel_create(api, channel_depth, chid) != RC_OK) {
     ta_log_error("%s\n", ta_error_to_string(SC_MAM_FAILED_CREATE_OR_GET_ID));
@@ -346,7 +350,7 @@ static bool is_setting_changed(const iota_client_service_t *const service, mam_a
   // TODO use `ta_find_transaction_objects(service, txn_req, txn_res)` instead of the original 'iota.c' function
   retcode_t ret_rc = iota_client_find_transaction_objects(service, txn_req, txn_res);
   if (ret_rc && ret_rc != RC_NULL_PARAM) {
-    ta_log_error("%s\n", SC_MAM_FAILED_DESTROYED);
+    ta_log_error("%s\n", ta_error_to_string(SC_MAM_FAILED_DESTROYED));
     goto done;
   }
 

connectivity/mqtt/duplex_utils.c

@@ -47,7 +47,7 @@ status_t duplex_config_init(struct mosquitto **config_mosq, mosq_config_t *confi
   init_check_error(config_cfg, client_pub);
 
   *config_mosq = mosquitto_new(config_cfg->general_config->id, true, NULL);
-  if (!config_mosq) {
+  if (!(*config_mosq)) {
     switch (errno) {
       case ENOMEM:
         ta_log_error("%s\n", "Out of memory");

storage/scylladb_permanode.c

@@ -339,6 +339,7 @@ static status_t get_trytes(CassSession* session, CassStatement* statement, hash8
     if (hash8019_queue_push(res_queue, (flex_trit_t const* const)buf) != RC_OK) {
       ta_log_error("%s\n", "SC_OOM");
       ret = SC_OOM;
+      goto end_iterate;
     }
     ret = SC_OK;
   }