Merge pull request #644 from afcidk/regression-test

fix(regression): Erroneous response verification

Author: jserv

tests/regression/test_suite/send_transfer.py

@@ -7,7 +7,7 @@
 
 class SendTransfer(unittest.TestCase):
 
-    # Positive value, tryte maessage, tryte tag, tryte address (pass)
+    # Positive value, tryte message, tryte tag, tryte address (pass)
     @test_logger
     def test_normal(self):
         res = API("/transaction/",
@@ -26,6 +26,7 @@ def test_zero_value(self):
     def test_chinese_value(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[2]))
+        self._verify_pass(res)
 
     # Zero value, chinese message, tryte tag, tryte address (fail)
     @test_logger
@@ -41,68 +42,68 @@ def test_chinese_tag(self):
                   post_data=map_field(self.post_field, self.query_string[4]))
         self.assertEqual(STATUS_CODE_500, res["status_code"])
 
-    # Negative value, tryte maessage, tryte tag, tryte address (pass)
+    # Negative value, tryte message, tryte tag, tryte address (pass)
     @test_logger
     def test_negative_value(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[5]))
         self._verify_pass(res)
 
-    # No value, tryte maessage, tryte tag, tryte address (pass)
+    # No value, tryte message, tryte tag, tryte address (pass)
     @test_logger
     def test_no_value(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[6]))
         self._verify_pass(res)
 
-    # Zero value, no maessage, tryte tag, tryte address (pass)
+    # Zero value, no message, tryte tag, tryte address (pass)
     @test_logger
     def test_no_message(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[7]))
         self._verify_pass(res)
 
-    # Zero value, tryte maessage, no tag, tryte address (pass)
+    # Zero value, tryte message, no tag, tryte address (pass)
     @test_logger
     def test_no_tag(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[8]))
         self._verify_pass(res)
 
-    # Zero value, tryte maessage, tryte tag, no address (pass)
+    # Zero value, tryte message, tryte tag, no address (pass)
     @test_logger
     def test_no_address(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[9]))
         self._verify_pass(res)
 
-    # Zero value, tryte maessage, tryte tag, unicode address (pass)
+    # Zero value, tryte message, tryte tag, unicode address (fail)
     @test_logger
     def test_unicode_address(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[10]))
-        self._verify_pass(res)
+        self.assertEqual(STATUS_CODE_500, res["status_code"])
 
-    # Zero value, tryte maessage, invalid tag, tryte address (fail)
+    # Zero value, tryte message, invalid tag, tryte address (fail)
     @test_logger
     def test_invalid_tag(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[11]))
-        self._verify_pass(res)
+        self.assertEqual(STATUS_CODE_500, res["status_code"])
 
-    # Zero value, tryte maessage, tryte tag, invalid address (fail)
+    # Zero value, tryte message, tryte tag, invalid address (fail)
     @test_logger
     def test_invalid_address(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[12]))
-        self._verify_pass(res)
+        self.assertEqual(STATUS_CODE_500, res["status_code"])
 
-    # Zero value, tryte maessage, invalid tag, invalid address (fail)
+    # Zero value, tryte message, invalid tag, invalid address (fail)
     @test_logger
     def test_invalid_tag_and_address(self):
         res = API("/transaction/",
                   post_data=map_field(self.post_field, self.query_string[13]))
-        self._verify_pass(res)
+        self.assertEqual(STATUS_CODE_500, res["status_code"])
 
     # Time statistics
     @test_logger