From 19f2f5c316b9fcd3f5a525ae174f8c154a639e04 Mon Sep 17 00:00:00 2001 From: Abirdcfly Date: Wed, 10 Aug 2022 17:19:44 +0800 Subject: [PATCH] fix minor unreachable code Signed-off-by: Abirdcfly --- cmd/geth/les_test.go | 2 -- node/config_test.go | 9 +++------ p2p/netutil/error_test.go | 1 - 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/cmd/geth/les_test.go b/cmd/geth/les_test.go index cc0f09528b..654bcb7e0c 100644 --- a/cmd/geth/les_test.go +++ b/cmd/geth/les_test.go @@ -93,10 +93,8 @@ func (g *gethrpc) waitSynced() { g.geth.Log("Other 'syncing' event", ev) case err := <-sub.Err(): g.geth.Fatalf("%v notification: %v", g.name, err) - break case <-timeout: g.geth.Fatalf("%v timeout syncing", g.name) - break } } diff --git a/node/config_test.go b/node/config_test.go index a6809051a8..281803e3d9 100644 --- a/node/config_test.go +++ b/node/config_test.go @@ -78,9 +78,9 @@ func TestDatadirCreation(t *testing.T) { node, err = New(&Config{DataDir: dir}) if err == nil { t.Fatalf("protocol stack created with an invalid datadir") - if err := node.Close(); err != nil { - t.Fatalf("failed to close node: %v", err) - } + } + if err := node.Close(); err != nil { + t.Fatalf("failed to close node: %v", err) } } @@ -212,7 +212,6 @@ func TestConfig_ResolvePluginBaseDir_whenBaseDirExists(t *testing.T) { } // Quorum -// func TestConfig_IsPermissionEnabled_whenTypical(t *testing.T) { tmpdir, err := ioutil.TempDir("", "q-") if err != nil { @@ -233,7 +232,6 @@ func TestConfig_IsPermissionEnabled_whenTypical(t *testing.T) { } // Quorum -// func TestConfig_IsPermissionEnabled_whenPermissionedFlagIsFalse(t *testing.T) { testObject := &Config{ EnableNodePermission: false, @@ -243,7 +241,6 @@ func TestConfig_IsPermissionEnabled_whenPermissionedFlagIsFalse(t *testing.T) { } // Quorum -// func TestConfig_IsPermissionEnabled_whenPermissionConfigIsNotAvailable(t *testing.T) { testObject := &Config{ EnableNodePermission: true, diff --git a/p2p/netutil/error_test.go b/p2p/netutil/error_test.go index 645e48f837..84d5c2c206 100644 --- a/p2p/netutil/error_test.go +++ b/p2p/netutil/error_test.go @@ -66,7 +66,6 @@ func TestIsPacketTooBig(t *testing.T) { for i := range buf { if buf[i] != byte(i) { t.Fatalf("error in pattern") - break } } }