always evaluate right side of _ := foo()

sauerbraten · sauerbraten · commit f67efbcea6a7 · 2020-08-12T13:12:55.000+02:00
fixup 9761f65
diff --git a/eval.go b/eval.go
@@ -319,8 +319,9 @@ func (st *Runtime) executeLetList(set *SetNode) {
 		}
 	} else {
 		for i := 0; i < len(set.Left); i++ {
+			value := st.evalPrimaryExpressionGroup(set.Right[i])
 			if set.Left[i].Type() != NodeUnderscore {
-				st.variables[set.Left[i].(*IdentifierNode).Ident] = st.evalPrimaryExpressionGroup(set.Right[i])
+				st.variables[set.Left[i].(*IdentifierNode).Ident] = value
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -319,8 +319,9 @@ func (st Runtime) executeLetList(set SetNode) {`
`319`	`319`	`}`
`320`	`320`	`} else {`
`321`	`321`	`for i := 0; i < len(set.Left); i++ {`
	`322`	`+ value := st.evalPrimaryExpressionGroup(set.Right[i])`
`322`	`323`	`if set.Left[i].Type() != NodeUnderscore {`
`323`		`- st.variables[set.Left[i].(*IdentifierNode).Ident] = st.evalPrimaryExpressionGroup(set.Right[i])`
	`324`	`+ st.variables[set.Left[i].(*IdentifierNode).Ident] = value`
`324`	`325`	`}`
`325`	`326`	`}`
`326`	`327`	`}`