Raising a panic in the includeIfExists helper when templates does exist but fails to render.

Author: diogogmt

default.go

@@ -83,6 +83,10 @@ func init() {
 
 			a.RequireNumOfArguments("includeIfExists", 1, 2)
 			t, err := a.runtime.set.GetTemplate(a.Get(0).String())
+			// If template exists but returns an error then panic instead of failing silently
+			if t != nil && err != nil {
+				panic(err)
+			}
 			if err != nil {
 				return hiddenFALSE
 			}

eval_test.go

@@ -364,6 +364,17 @@ func TestIncludeIfNotExists(t *testing.T) {
 	RunJetTestWithSet(t, set, nil, nil, "notExistent", "", "")
 	RunJetTestWithSet(t, set, nil, nil, "ifIncludeIfExits", "", "Hi, i exist!!\n    Was included!!\n\n\n    Was not included!!\n\n")
 	RunJetTestWithSet(t, set, nil, "World", "wcontext", "", "Hi, Buddy!\nHi, World!")
+
+	// Check if includeIfExists helper bubbles up runtime errors of included templates
+	tt, err := set.GetTemplate("includeBroken")
+	if err != nil {
+		t.Error(err)
+	}
+	buff := bytes.NewBuffer(nil)
+	err = tt.Execute(buff, nil, nil)
+	if err == nil {
+		t.Error("expected includeIfExists helper to fail with a runtime error but got nil")
+	}
 }
 
 func TestSet_Parse(t *testing.T) {

testData/includeIfNotExists/broken.jet

@@ -0,0 +1 @@
+{{ err.break }}

testData/includeIfNotExists/includeBroken.jet

@@ -0,0 +1 @@
+{{ includeIfExists: "broken.jet"}}