Skip to content

Commit c34cf10

Browse files
author
lidong
committed
fix #25 pip install failed but build success
1 parent 674cfb9 commit c34cf10

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

zipapps/ensure_zipapps.py.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def prepare_path():
186186
os.chdir(_cache_folder_path_str)
187187
try:
188188
pip_main = get_pip_main(ensurepip_root=lazy_pip_dir_str)
189-
pip_main(_pip_args)
189+
assert pip_main(_pip_args) == 0, 'pip install failed'
190190
finally:
191191
os.chdir(cwd)
192192
# avoid duplicated installation

zipapps/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ def pip_install(self):
397397
target = str(self._cache_path.absolute())
398398
_pip_args = ['install', '--target', target] + self.pip_args
399399
pip_main = get_pip_main()
400-
pip_main(_pip_args)
400+
assert pip_main(_pip_args) == 0, 'pip install failed'
401401
self.clean_pip_pycache()
402402

403403
def clean_pip_pycache(self):

0 commit comments

Comments
 (0)