use libgmp for bignum instead of num-bigint

Author: arvidn

.github/workflows/benchmark.yml

@@ -54,6 +54,7 @@ jobs:
         git clone https://github.com/Chia-Network/clvm_tools.git --branch=main --single-branch
         python -m pip install ./clvm_tools
         python -m pip install colorama
+        git clone https://github.com/Chia-Network/mpir_gc_x64.git --depth 1
         maturin develop --release
 
     - name: Run benchmarks (Windows)
@@ -62,6 +63,13 @@ jobs:
         . .\venv\Scripts\Activate.ps1
         python benchmark/run-benchmark.py
 
+    - name: Install GMP
+      if: ${{ startsWith(matrix.os, 'ubuntu') }}
+      run: |
+        sudo apt install libgmp3-dev
+        ls -la /usr/lib64
+        ls -la /usr/lib
+
     - name: Build
       if: ${{ !startsWith(matrix.os, 'windows') }}
       env:
@@ -108,6 +116,9 @@ jobs:
       run: |
         python -m pip install maturin
         rustup target add x86_64-unknown-linux-musl
+        sudo apt install libgmp3-dev
+        ls -la /usr/lib64
+        ls -la /usr/lib
 
     - name: Build
       env:

.github/workflows/build-arm64-wheels.yml

@@ -42,6 +42,8 @@ jobs:
             curl -L https://sh.rustup.rs > rustup-init.sh && \
             sh rustup-init.sh -y && \
             yum -y install openssl-devel && \
+            yum -y install gmp && \
+            ls -la /usr/lib64/ && \
             source $HOME/.cargo/env && \
             rustup target add aarch64-unknown-linux-musl && \
             rm -rf venv && \

.github/workflows/build-crate-and-npm.yml

@@ -39,6 +39,8 @@ jobs:
       run: cargo +stable fmt -- --files-with-diff --check
     - name: clippy (stable)
       run: cargo +stable clippy
+    - name: install GMP
+      run: sudo apt install libgmp3-dev
     - name: tests
       run: cargo test && cargo test --release
     - name: build

.github/workflows/build-m1-wheel.yml

@@ -37,6 +37,16 @@ jobs:
         curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs > rust.sh
         arch -arm64 sh rust.sh -y
 
+    - name: install GMP
+      run: |
+        curl -L https://gmplib.org/download/gmp/gmp-6.2.1.tar.lz | tar x
+        cd gmp-6.2.1
+        ./configure --enable-fat --with-pic
+        make -j 6
+        sudo make install
+        cd ..
+        rm -rf gmp-6.2.1
+
     - name: Build m1 wheels
       run: |
         arch -arm64 python3 -m venv venv

.github/workflows/build-test.yml

@@ -47,6 +47,7 @@ jobs:
     - name: Build MacOs with maturin on Python ${{ matrix.python }}
       if: startsWith(matrix.os, 'macos')
       run: |
+        brew install gmp
         python -m venv venv
         ln -s venv/bin/activate
         . ./activate
@@ -70,6 +71,8 @@ jobs:
             curl -L https://sh.rustup.rs > rustup-init.sh && \
             sh rustup-init.sh -y && \
             yum -y install openssl-devel && \
+            yum -y install gmp && \
+            ls -la /usr/lib64 && \
             source $HOME/.cargo/env && \
             rustup target add x86_64-unknown-linux-musl && \
             rm -rf venv && \
@@ -95,6 +98,7 @@ jobs:
         python -m venv venv
         . .\venv\Scripts\Activate.ps1
         ln -s venv\Scripts\Activate.ps1 activate
+        git clone https://github.com/Chia-Network/mpir_gc_x64.git --depth 1
         maturin build --no-sdist -i python --release --strip
         # this will install into the venv
         # it'd be better to use the wheel, but I can't figure out how to do that
@@ -227,6 +231,8 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
             toolchain: nightly
+      - name: install GMP
+        run: sudo apt install libgmp3-dev
       - name: cargo-fuzz
         run: cargo +nightly install cargo-fuzz
       - name: build
@@ -244,5 +250,7 @@ jobs:
         with:
             toolchain: stable
             components: rustfmt, clippy
+      - name: install GMP
+        run: sudo apt install libgmp3-dev
       - name: cargo test
         run: cargo test

Cargo.lock

@@ -23,9 +23,6 @@ default = ["extension-module"]
 [dependencies]
 hex = "=0.4.3"
 lazy_static = "=1.4.0"
-num-bigint = "=0.4.0"
-num-traits = "=0.2.14"
-num-integer = "=0.1.44"
 bls12_381 = "=0.5.0"
 sha2 = "=0.9.5"
 openssl = { version = "0.10.35", features = ["vendored"], optional = true }

Cargo.toml

@@ -9,6 +9,12 @@ Use `maturin` to build the python interface. First, install into current virtual
 $ pip install maturin
 ```
 
+As we need `MPIR` for MSVC builds, prepare this dependency with
+
+```
+$ git clone https://github.com/Chia-Network/mpir_gc_x64.git --depth 1
+```
+
 Build `clvm_rs` directly into the current virtualenv with
 
 ```

README.md

@@ -0,0 +1,18 @@
+fn main() {
+    #[cfg(target_os = "windows")]
+    {
+        println!("cargo:rustc-link-lib=mpir");
+        println!("cargo:rustc-link-search=mpir_gc_x64");
+    }
+    #[cfg(target_os = "linux")]
+    {
+        println!("cargo:rustc-link-lib=gmp");
+        println!("cargo:rustc-link-search=/usr/lib64");
+        println!("cargo:rustc-link-search=/usr/lib");
+    }
+    #[cfg(target_os = "macos")]
+    {
+        println!("cargo:rustc-link-lib=gmp");
+        println!("cargo:rustc-link-search=/opt/homebrew/lib");
+    }
+}

build.rs

@@ -555,8 +555,6 @@ use crate::serialize::node_to_bytes;
 #[cfg(test)]
 use hex::FromHex;
 #[cfg(test)]
-use num_traits::Num;
-#[cfg(test)]
 use std::collections::HashMap;
 
 #[cfg(test)]
@@ -689,7 +687,7 @@ fn parse_list_impl(
         (a.new_atom(&buf).unwrap(), v.len() + 1)
     } else if input.starts_with("-") || "0123456789".contains(input.get(0..1).unwrap()) {
         let v = input.split_once(" ").unwrap().0;
-        let num = Number::from_str_radix(v, 10).unwrap();
+        let num = Number::from_str_radix(v, 10);
         (ptr_from_number(a, &num).unwrap(), v.len() + 1)
     } else {
         panic!("atom not supported \"{}\"", input);