Skip to content

Commit 8da5f48

Browse files
committed
fix: when key had invalid char, lookup would not use same name.
1 parent 8c3fb0c commit 8da5f48

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

Catglobe.ResXFileCodeGenerator.Tests/IntegrationTests/TestLookup.da.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
<resheader name="writer">
9999
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.3500.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
100100
</resheader>
101-
<data name="CreateDate" xml:space="preserve">
101+
<data name="$CreateDate%" xml:space="preserve">
102102
<value>OldestDa</value>
103103
</data>
104104
<data name="CreateDateDescending" xml:space="preserve">

Catglobe.ResXFileCodeGenerator.Tests/IntegrationTests/TestLookup.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
<resheader name="writer">
9999
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.3500.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
100100
</resheader>
101-
<data name="CreateDate" xml:space="preserve">
101+
<data name="$CreateDate%" xml:space="preserve">
102102
<value>Oldest</value>
103103
</data>
104104
<data name="CreateDateDescending" xml:space="preserve">

Catglobe.ResXFileCodeGenerator/StringBuilderGenerator.EnumGenerator.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace Catglobe.ResXFileCodeGenerator;
1+
using System.Xml.Linq;
2+
3+
namespace Catglobe.ResXFileCodeGenerator;
24

35
internal sealed partial class StringBuilderGenerator : IGenerator
46
{
@@ -97,7 +99,7 @@ private void GenerateLookup(
9799
builder.Append(memberName.Key);
98100
builder.Append('"');
99101
builder.Append(" => ");
100-
builder.Append(memberName.Key);
102+
builder.Append(s_invalidMemberNameSymbols.Replace(memberName.Key, "_"));
101103
builder.AppendLineLF(",");
102104
}
103105
builder.Append(' ', indent);

0 commit comments

Comments
 (0)