lib/helpers: some SC2034 fixes

And SC2154 in `_make_reload_alias()`

Author: gaelicWizard

lib/helpers.bash

@@ -14,6 +14,7 @@ BASH_IT_LOAD_PRIORITY_SEPARATOR="---"
 # To use this in Bash-it for inline replacements with `sed`, use the following syntax:
 # sed "${BASH_IT_SED_I_PARAMETERS[@]}" -e "..." file
 BASH_IT_SED_I_PARAMETERS=(-i)
+# shellcheck disable=SC2034 # expected for this case
 case "$OSTYPE" in
   'darwin'*) BASH_IT_SED_I_PARAMETERS=(-i "")
 esac
@@ -80,7 +81,7 @@ function _bash_it_homebrew_check()
 }
 
 function _make_reload_alias() {
-  echo "source '${BASH_IT}/scripts/reloader.bash' '${1}' '${2}'"
+  echo "source '${BASH_IT?}/scripts/reloader.bash' '${1?}' '${2?}'"
 }
 
 # Alias for reloading aliases
@@ -443,30 +444,30 @@ _bash-it-doctor() {
   _param '1: BASH_IT_LOG_LEVEL argument: "errors" "warnings" "all"'
   _group 'lib'
 
-  BASH_IT_LOG_LEVEL=$1
+  # shellcheck disable=SC2034 # expected for this case
+  local BASH_IT_LOG_LEVEL="${1?}"
   _bash-it-reload
-  unset BASH_IT_LOG_LEVEL
 }
 
 _bash-it-doctor-all() {
   _about 'reloads a profile file with error, warning and debug logs'
   _group 'lib'
 
-  _bash-it-doctor "$BASH_IT_LOG_LEVEL_ALL"
+  _bash-it-doctor "${BASH_IT_LOG_LEVEL_ALL?}"
 }
 
 _bash-it-doctor-warnings() {
   _about 'reloads a profile file with error and warning logs'
   _group 'lib'
 
-  _bash-it-doctor "$BASH_IT_LOG_LEVEL_WARNING"
+  _bash-it-doctor "${BASH_IT_LOG_LEVEL_WARNING?}"
 }
 
 _bash-it-doctor-errors() {
   _about 'reloads a profile file with error logs'
   _group 'lib'
 
-  _bash-it-doctor "$BASH_IT_LOG_LEVEL_ERROR"
+  _bash-it-doctor "${BASH_IT_LOG_LEVEL_ERROR?}"
 }
 
 _bash-it-doctor-() {