undo hacks

Author: majastrz

src/Bicep.LangServer.IntegrationTests/CompletionTests.cs

@@ -40,7 +40,6 @@ namespace Bicep.LangServer.IntegrationTests
     [SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods", Justification = "Test methods do not need to follow this convention.")]
     public class CompletionTests
     {
-        // cache the provider
         public static readonly IResourceTypeProvider TypeProvider = AzResourceTypeProvider.CreateWithAzTypes();
 
         [NotNull]
@@ -561,7 +560,7 @@ static void AssertAllCompletionsContainResourceLabel(IEnumerable<CompletionList?
                 }
             }
 
-            await RunCompletionScenarioTest(fileWithCursors, AssertAllCompletionsContainResourceLabel);
+            await RunCompletionScenarioTest(this.TestContext, fileWithCursors, AssertAllCompletionsContainResourceLabel);
         }
 
         [TestMethod]
@@ -646,15 +645,6 @@ private static async Task RunCompletionScenarioTest(TestContext testContext, str
             assertAction(completions);
         }
 
-        private static Task RunCompletionScenarioTest(object testContext, Action<IEnumerable<CompletionList?>> assertAction222)
-        {
-            /*
-             * The compiler on GitHub actions seems to believe that we are only passing 2 arguments to this method. 
-             * Let's make that true, so we can compile the code successfully to get a stack trace at runtime.
-             */
-            throw new NotImplementedException("This should not be getting called!!!");
-        }
-
         private static void AssertAllCompletionsNonEmpty(IEnumerable<CompletionList?> completionLists)
         {
             foreach (var completionList in completionLists)
@@ -775,7 +765,7 @@ value is null
                 if (value is JObject @object)
                 {
                     const string omnisharpHandlerIdPropertyName = "$$__handler_id__$$";
-                
+
                     if (@object.Property(omnisharpHandlerIdPropertyName) != null)
                     {
                         @object.Remove(omnisharpHandlerIdPropertyName);