[BUG]  The visibility of getImageGenerationsWithResponse should be public

**Describe the bug**

The interface `com.azure.ai.openai.OpenAIAsyncClient#getImageGenerationsWithResponse(java.lang.String, com.azure.core.util.BinaryData, com.azure.core.http.rest.RequestOptions)` currently uses the default visibility, which is protected.

https://github.com/Azure/azure-sdk-for-java/blob/7adf7f69a52498531502b5c5b0577769452619c9/sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java#L1524-L1530

 I believe it should be `public`, as this is inconsistent with other similar interfaces, such as: 

`com.azure.ai.openai.OpenAIClient#getChatCompletionsWithResponse(java.lang.String, com.azure.core.util.BinaryData, com.azure.core.http.rest.RequestOptions)`:

https://github.com/Azure/azure-sdk-for-java/blob/7adf7f69a52498531502b5c5b0577769452619c9/sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java#L345-L352

`com.azure.ai.openai.OpenAIClient#getEmbeddingsWithResponse(java.lang.String, com.azure.core.util.BinaryData, com.azure.core.http.rest.RequestOptions)`:

https://github.com/Azure/azure-sdk-for-java/blob/7adf7f69a52498531502b5c5b0577769452619c9/sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java#L162-L169 

and `com.azure.ai.openai.OpenAIClient#getAudioTranscriptionWithResponse`:

https://github.com/Azure/azure-sdk-for-java/blob/7adf7f69a52498531502b5c5b0577769452619c9/sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java#L948-L953


	Mono<Response<BinaryData>> getImageGenerationsWithResponse(String deploymentOrModelName,
	BinaryData imageGenerationOptions, RequestOptions requestOptions) {
	return this.openAIServiceClient != null
	? this.openAIServiceClient.getImageGenerationsWithResponseAsync(deploymentOrModelName,
	imageGenerationOptions, requestOptions)
	: this.serviceClient.getImageGenerationsWithResponseAsync(deploymentOrModelName, imageGenerationOptions,
	requestOptions);

	public Response<BinaryData> getChatCompletionsWithResponse(String deploymentOrModelName,
	BinaryData chatCompletionsOptions, RequestOptions requestOptions) {
	return openAIServiceClient != null
	? openAIServiceClient.getChatCompletionsWithResponse(deploymentOrModelName, chatCompletionsOptions,
	requestOptions)
	: serviceClient.getChatCompletionsWithResponse(deploymentOrModelName, chatCompletionsOptions,
	requestOptions);
	}

	public Response<BinaryData> getEmbeddingsWithResponse(String deploymentOrModelName, BinaryData embeddingsOptions,
	RequestOptions requestOptions) {
	final BinaryData embeddingsOptionsUpdated = addEncodingFormat(embeddingsOptions);
	return openAIServiceClient != null
	? openAIServiceClient.getEmbeddingsWithResponse(deploymentOrModelName, embeddingsOptionsUpdated,
	requestOptions)
	: serviceClient.getEmbeddingsWithResponse(deploymentOrModelName, embeddingsOptionsUpdated, requestOptions);
	}

	public Response<AudioTranscription> getAudioTranscriptionWithResponse(String deploymentOrModelName, String fileName,
	AudioTranscriptionOptions audioTranscriptionOptions, RequestOptions requestOptions) {
	// checking allowed formats for a JSON response
	validateAudioResponseFormatForTranscription(audioTranscriptionOptions);
	// embedding the `model` in the request for non-Azure case
	if (this.openAIServiceClient != null) {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BUG] The visibility of getImageGenerationsWithResponse should be public #46101

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[BUG] The visibility of getImageGenerationsWithResponse should be public #46101

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions