Catch non React exports defined as call expressions [publish]

Author: ArnaudBarre

.github/workflows/ci.yml

@@ -13,4 +13,4 @@ jobs:
           node-version: 22
       - uses: oven-sh/setup-bun@v2
       - run: bun install
-      - run: bun ci
+      - run: bun run ci

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.4.25
+
+- Report cases like `export const ENUM = Object.keys(TABLE) as EnumType[];` (fixes [#93](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/93))
+- Allow `_` in component names ([#94](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/pull/94))
+
 ## 0.4.24
 
 - Add `"generateImageMetadata"`, `"generateSitemaps"` & `"generateStaticParams"` to `allowExportNames` in Next config

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-refresh",
-  "version": "0.4.24",
+  "version": "0.4.25",
   "type": "module",
   "license": "MIT",
   "scripts": {

src/only-export-components.test.ts

@@ -338,6 +338,11 @@ const invalid = [
     code: "const MyComponent = () => {}; export default observer(MyComponent);",
     errorId: ["localComponents", "anonymousExport"],
   },
+  {
+    name: "Object.keys",
+    code: "const MyComponent = () => {}; export const ENUM = Object.keys(TABLE) as EnumType[];",
+    errorId: "localComponents",
+  },
 ];
 
 const it = (name: string, cases: Parameters<typeof ruleTester.run>[2]) => {

src/only-export-components.ts

@@ -106,8 +106,9 @@ export const onlyExportComponents: TSESLint.RuleModule<
         const handleExportIdentifier = (
           identifierNode: TSESTree.BindingName | TSESTree.StringLiteral,
           isFunction?: boolean,
-          init?: TSESTree.Expression | null,
+          initParam?: TSESTree.Expression | null,
         ) => {
+          const init = initParam ? skipTSWrapper(initParam) : null;
           if (identifierNode.type !== "Identifier") {
             nonComponentExports.push(identifierNode);
             return;
@@ -116,7 +117,7 @@ export const onlyExportComponents: TSESLint.RuleModule<
           if (
             allowConstantExport
             && init
-            && constantExportExpressions.has(skipTSWrapper(init).type)
+            && constantExportExpressions.has(init.type)
           ) {
             return;
           }
@@ -141,6 +142,14 @@ export const onlyExportComponents: TSESLint.RuleModule<
               reactContextExports.push(identifierNode);
               return;
             }
+            if (init && init.type === "CallExpression") {
+              if (isHOCCallExpression(init)) {
+                hasReactExport = true;
+              } else {
+                nonComponentExports.push(identifierNode);
+              }
+              return;
+            }
             if (
               init
               // Switch to allowList?