Skip to content

Commit 0879118

Browse files
atoulmemx-psi
authored andcommitted
[internal/aws/proxy] adopt component.UseLocalHostAsDefaultHost feature gate (open-telemetry#30987)
Description: internal/aws/proxy adopts `component.UseLocalHostAsDefaultHost` feature gate Link to tracking Issue: open-telemetry#30702 Fixes open-telemetry#30986 Documentation: Updated docs. --------- Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
1 parent 142c1e9 commit 0879118

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

.chloggen/mx-psi_internal-localhostgate.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ subtext: |
2020
- extension/awsproxy
2121
- extension/health_check
2222
- extension/jaegerremotesampling
23+
- internal/aws/proxy
2324
- processor/remotetap
2425
- receiver/awsfirehose
2526
- receiver/awsxray

internal/aws/proxy/cfg.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ package proxy // import "github.com/open-telemetry/opentelemetry-collector-contr
66
import (
77
"go.opentelemetry.io/collector/config/confignet"
88
"go.opentelemetry.io/collector/config/configtls"
9+
10+
"github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/localhostgate"
911
)
1012

1113
// Config is the configuration for the local TCP proxy server.
@@ -43,7 +45,7 @@ type Config struct {
4345
func DefaultConfig() *Config {
4446
return &Config{
4547
TCPAddr: confignet.TCPAddr{
46-
Endpoint: "0.0.0.0:2000",
48+
Endpoint: localhostgate.EndpointForPort(2000),
4749
},
4850
ProxyAddress: "",
4951
TLSSetting: configtls.TLSClientSetting{

receiver/awsxrayreceiver/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ The TCP address and port on which this receiver listens for calls from the X-Ray
6363

6464
Default: `0.0.0.0:2000`
6565

66+
The `component.UseLocalHostAsDefaultHost` feature gate changes this to localhost:2000. This will become the default in a future release.
67+
6668
### proxy_address (Optional)
6769
Defines the proxy address that the local TCP server forwards HTTP requests to AWS X-Ray backend through. If left unconfigured, requests will be sent directly.
6870

0 commit comments

Comments
 (0)